Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optionally skip urlencoding client id and secret in header #710

Open
bachmanity1 opened this issue Mar 5, 2024 · 4 comments · May be fixed by #708
Open

optionally skip urlencoding client id and secret in header #710

bachmanity1 opened this issue Mar 5, 2024 · 4 comments · May be fixed by #708

Comments

@bachmanity1
Copy link

This is related to #237.

Although https://tools.ietf.org/html/rfc6749#section-2.3.1 states that clientID & clientSecret must be url encoded in the authorization header some sites don't do this thus resulting in authentication failure.
@bachmanity1 bachmanity1 linked a pull request Mar 5, 2024 that will close this issue
Open
@bachmanity1
Copy link
Author

@quartzmo @BigTailWolf can you have look please?

@quartzmo
Copy link
Contributor

This is out of scope for me, I help to maintain the Google Cloud functionality in the google subpackage.

@bachmanity1
Copy link
Author

This is out of scope for me, I help to maintain the Google Cloud functionality in the google subpackage.

Thanks for your reply! If possible could you please tag someone who could help me? I have authored a PR which has been open for more than 3 weeks now but there hasn't been any reply yet.

@quartzmo
Copy link
Contributor

@bachmanity1 I'm sorry, I don't know who can help. Outside of the google subpackage, I have no inside knowledge of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal: optionally skip urlencoding client id and secret in header bachmanity1/oauth2
2 participants
@quartzmo @bachmanity1