{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27146054,"defaultBranch":"master","name":"tools","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-25T21:07:26.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713203739.0","currentOid":""},"activityList":{"items":[{"before":"c16c816ac486df69471674bcaf6f1a8f76f2bdcf","after":"e2a352c850a52c32b9bfdb78fbfb97882b7c1424","ref":"refs/heads/master","pushedAt":"2024-05-04T23:00:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/refactor/inline: extensible API\n\nThis CL introduces Options and Result struct types to the\npublic Inline function so that we can extend the input\nand outputs as needed.\n\nOptions.IgnoreEffects allows a client to choose to\nignore consideration of potential side effects of\ncall arguments, an unsound \"style optimization\".\n\nResult.Literalized reports whether the chosen strategy\nwas literalization. (Some clients may reject the\ntransformation in that case.)\n\nA follow-up change will refine the API to separate\nthe diff at the callsite from the logical diff to\nthe import declaration.\n\nUpdates golang/go#67049\n\nChange-Id: Ifcec19d8cfd18fa797e16c7d6994ac916d77dab5\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581802\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/refactor/inline: extensible API"}},{"before":"4db16973aa22c2c1a5a873261a68949f351efe2b","after":"c16c816ac486df69471674bcaf6f1a8f76f2bdcf","ref":"refs/heads/master","pushedAt":"2024-05-03T23:18:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/analysis/passes/stdversion: test *.go < go.mod version\n\nThis CL adds two tests for when the file's Go version\n(set by a //go:build constraint) is lower than the module's\nGo version.\n\nWith a go.mod version < go1.21, the start of the \"extended forward\ncompatibility\" regime, stdversion is silent. But with go1.21+,\nthe build constraint in the file overrides the Go module version,\neven when lower.\n\nFixes golang/go#67123\n\nChange-Id: Iba37ff2d2c6d0e42a5bd0fe80bbd8dc6b1a25ac9\nReviewed-on: https://go-review.googlesource.com/c/tools/+/582936\nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/analysis/passes/stdversion: test *.go < go.mod version"}},{"before":"ccdef3cc2699ea2a30a2931a43a1774bd974000a","after":"4db16973aa22c2c1a5a873261a68949f351efe2b","ref":"refs/heads/master","pushedAt":"2024-05-03T22:19:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/packages/packagestest: fold modules_111.go into modules.go\n\nx/tools hasn't supported Go versions earlier than 1.11 (or even 1.11\nitself) for a while.\n\nChange-Id: I723c43dbcd1c4df56d8c663a78ec31524b912985\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581795\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"go/packages/packagestest: fold modules_111.go into modules.go"}},{"before":"74c9cfe4d22faa696baabeea02df6493b15e8c79","after":"ccdef3cc2699ea2a30a2931a43a1774bd974000a","ref":"refs/heads/master","pushedAt":"2024-05-02T22:38:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: fix nil panic in InlayHint\n\nFixes golang/go#67142\n\nChange-Id: Iee99c1fb0378c409bbbe803ad66b99a068e6d4bc\nReviewed-on: https://go-review.googlesource.com/c/tools/+/582957\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/golang: fix nil panic in InlayHint"}},{"before":"5ef4fc9014e76bcc56324b24218c0216a7146306","after":"74c9cfe4d22faa696baabeea02df6493b15e8c79","ref":"refs/heads/master","pushedAt":"2024-04-29T17:36:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/analysis: add Pass.ReadFile\n\nThe ReadFile function enables an analyzer to read the contents\nof a file through the driver. The allows the driver to provide\nthe analyzer with a view of the file system that is consistent\nwith that seen by the parser and type checker, and enables\ndrivers to reject attempts to read arbitrary files, so that\ntheir dependency analysis (if any) can be sound and precise.\n\n+ a test\n\nFixes golang/go#62292\n\nChange-Id: I9f301cbfd4a705a259f9e213fc2e63d74424294a\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581555\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"go/analysis: add Pass.ReadFile"}},{"before":"77f691badad098462fed0a46c9a3f5f3d178b633","after":"5ef4fc9014e76bcc56324b24218c0216a7146306","ref":"refs/heads/master","pushedAt":"2024-04-29T15:14:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang/completion: fix the isEmptyInterface predicate\n\nThe isEmptyInterface predicate had a TODO noting that it should probably\nbe considering the underlying type. After looking at usage, I agree that\nthis was probably simple any oversight, but didn't matter because most\nuses of the empty interface were uses of any or interface{}, both of\nwhich were an interface.\n\nBut with CL 580355, as the 'any' type is becoming a types.Alias, and\nthis logic is caused inference scoring to change and gopls tests to\nfail. Fix isEmptyInterface to check underlying, and add a bit of\ncommentary for the future.\n\nFor golang/go#66921\n\nChange-Id: I7ba3db1b04d83dda0372d9c39b943965f4d8c955\nReviewed-on: https://go-review.googlesource.com/c/tools/+/582335\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang/completion: fix the isEmptyInterface predicate"}},{"before":"0b45163525d65fb3eda8170c40d6765eb98ddf4d","after":"77f691badad098462fed0a46c9a3f5f3d178b633","ref":"refs/heads/master","pushedAt":"2024-04-29T14:54:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/gcimporter: use Alias.Rhs, not unsafe hack\n\nUnfortunately we need an aliases.Rhs shim to handle the\nthree cases (before, at, after go1.22).\n\n(Alias.Rhs was recently added in CL CL 581615.)\n\nUpdates golang/go#66559\n\nChange-Id: I25a35c14f3ef5ddb77712afcce17f960dd181b5c\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581635\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/gcimporter: use Alias.Rhs, not unsafe hack"}},{"before":"3c49bb7830a4ceeb2dec163c8bed04e1b17edc8c","after":"0b45163525d65fb3eda8170c40d6765eb98ddf4d","ref":"refs/heads/master","pushedAt":"2024-04-26T20:48:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: use language versions when validating Go version\n\nThe check in CL 576678 was comparing the release version, which is a\nlanguage version, with the contents of the go directive, which may be a\ntoolchain version. As a result, gopls detects go1.22 < go1.22.2, and\ndoes not set types.Config.GoVersion. Normally this would be acceptable,\nsince go/types falls back on allowing all language features.\nUnfortunately, gopls@v0.15.x lacks CL 567635, and so the loopclosure\nanalyzer reports a diagnostic in this case.\n\nFix by comparing language versions.\n\nFixes golang/go#567635\n\nChange-Id: I13747f19e48186105967b9c777de5ca34908545f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579758\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King \n(cherry picked from commit 429c9f0c2c0d52afd4862e9734511a94fea841b7)\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581807\nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"gopls/internal/cache: use language versions when validating Go version"}},{"before":"cd70d50baa6daa949efa12e295e10829f3a7bd46","after":"429c9f0c2c0d52afd4862e9734511a94fea841b7","ref":"refs/heads/gopls-release-branch.0.15","pushedAt":"2024-04-26T20:30:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[gopls-release-branch.0.15] gopls/internal/cache: use language versions\nwhen validating Go version\n\nThe check in CL 576678 was comparing the release version, which is a\nlanguage version, with the contents of the go directive, which may be a\ntoolchain version. As a result, gopls detects go1.22 < go1.22.2, and\ndoes not set types.Config.GoVersion. Normally this would be acceptable,\nsince go/types falls back on allowing all language features.\nUnfortunately, gopls@v0.15.x lacks CL 567635, and so the loopclosure\nanalyzer reports a diagnostic in this case.\n\nFix by comparing language versions.\n\nFixes golang/go#567635\n\nChange-Id: I13747f19e48186105967b9c777de5ca34908545f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579758\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King ","shortMessageHtmlLink":"[gopls-release-branch.0.15] gopls/internal/cache: use language versions"}},{"before":"2fa621c35ec50263c4e6533e19e9f37dd98c7508","after":"3c49bb7830a4ceeb2dec163c8bed04e1b17edc8c","ref":"refs/heads/master","pushedAt":"2024-04-26T20:08:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: normalize logging attributes\n\nAs part of the log audit in golang/go#66746, I noticed several\nirregularities addressed by this CL:\n- Move \"tags\" (domain-specific event keys, which are used construct\n labels) closer to the packages that use them. Specifically, the\n internal/event/tag package contained gopls-specific tags, but x/tools\n should not care about gopls.\n- Use consistent values for log attributes. For example, \"method\" was\n being used to mean jsonrpc2 method and Go method. Also, \"directory\"\n was being used as both file path and URI.\n- Use log attributes for the view attributes logged when views are\n created.\n- Eliminate (yet another) redundant log during Load.\n- Include the ViewID with snapshot.Labels, since snapshot IDs are only\n meaningful relative to a View.\n\nWith these changes, my audit of logging is complete.\n\nFixes golang/go#66746\n\nChange-Id: Iaa60797a7412fb8e222e78e2e58eff2da9563bbb\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579335\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls: normalize logging attributes"}},{"before":"bcec0994e0bf81991b2e35f788768c9074a20152","after":"2fa621c35ec50263c4e6533e19e9f37dd98c7508","ref":"refs/heads/master","pushedAt":"2024-04-26T18:18:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: fix resolution of in-package implementations\n\nA rather egregious oversight in CL 518896 broke the query for\nimplementations in declaring packages, when the query originates from a\ndifferent package: the object was resolved *before* computing local\npackages.\n\nFix this by restoring the logic for finding the query type in the same\nrealm as the local packages.\n\nFixes golang/go#67041\n\nChange-Id: I5a111153154d66798e9ba87be9f0b3d0c792f973\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581875\nReviewed-by: Alan Donovan \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang: fix resolution of in-package implementations"}},{"before":"fcea13b66c45c5ca16dfb1d36479ec79d3d68c15","after":"bcec0994e0bf81991b2e35f788768c9074a20152","ref":"refs/heads/master","pushedAt":"2024-04-26T17:54:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/refactor/inline: remove eta abstraction inlining assignments\n\nRemove the unnecessary eta abstraction reported in golang/go#65217, by\nintroducing a new strategy for rewriting assignments.\n\nThis strategy involves analyzing both LHS and RHS of an assignment, and\nchoosing between three substrategies:\n - spread the result expressions in cases where types are unambiguous\n - predeclare LHS variables in cases where the return is itself a spread\n call\n - convert RHS expressions if types involve implicit conversions\n\nDoing this involved some fixes to the logic for detecting trivial\nconversions, and tracking some additional information about untyped nils\nin return expressions.\n\nSince this strategy avoids literalization by modifying assignments in\nplace, it must be able to avoid nested blocks, and so it explicitly\nrecords that braces may be elided.\n\nThere is more work to be done here, both improving the writeType helper,\nand by variable declarations, but this CL lays a foundation for later\nexpansion.\n\nFor golang/go#65217\n\nChange-Id: I9b3b595f7f678ab9b86ef7cf19936fd818b45426\nReviewed-on: https://go-review.googlesource.com/c/tools/+/580835\nReviewed-by: Alan Donovan \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/refactor/inline: remove eta abstraction inlining assignments"}},{"before":"b00d49ed93a1bf1d51b3a6254ba8155f65a797fb","after":"fcea13b66c45c5ca16dfb1d36479ec79d3d68c15","ref":"refs/heads/master","pushedAt":"2024-04-25T20:20:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"toolstash: errors output should match errors guarded\n\nThe errors guarded against in the `if` conditions are not the errors\nprinted with`log.Fatalf()` — instead, they are the same errors copied\nfrom the immediately-preceding error checks.\nMaybe some sort of copy-paste mistake.\n\nReasoning:\n- The error printed is always `nil` at the changed lines (`err1`).\n- The error printed should be a non-`nil` error (`err2`).\n\nChange-Id: I5e4c1e6a460fb37d9d8652b727e641db2245e3c5\nGitHub-Last-Rev: 77a4e86342e8efc9105f823dd6d70e6a6a611eed\nGitHub-Pull-Request: golang/tools#489\nReviewed-on: https://go-review.googlesource.com/c/tools/+/580235\nReviewed-by: Joedian Reid \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"toolstash: errors output should match errors guarded"}},{"before":"15234410046e3fe4c09979e1a11e1da6202073d6","after":"b00d49ed93a1bf1d51b3a6254ba8155f65a797fb","ref":"refs/heads/master","pushedAt":"2024-04-25T05:11:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/refactor/inline: don't assume strings.Index calls internal/bytealg\n\nI'm refactoring part of the strings package,\nand this assumption won't hold after.\n\nChange the test to use syscall.ByteSliceFromString;\nsyscall is mostly frozen and hopefully unlikely to change.\n\nChange-Id: I0bb536b32922c6d705d0ff7369f03c55a169d37f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581595\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"internal/refactor/inline: don't assume strings.Index calls internal/b…"}},{"before":"440f3c37e488bb7ea233aff0284492ef7e66ac36","after":"15234410046e3fe4c09979e1a11e1da6202073d6","ref":"refs/heads/master","pushedAt":"2024-04-23T20:28:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: add more assertions for golang/go#60890\n\nThis is one of our most frequent and oldest open crash bugs.\n\nUpdates golang/go#60890\n\nChange-Id: I97bdf339ec355aaf23fb81ee8fed11b142d28409\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581175\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/cache: add more assertions for golang/go#60890"}},{"before":"a363d11f520e51f57e123b358307fd91ce388c84","after":"440f3c37e488bb7ea233aff0284492ef7e66ac36","ref":"refs/heads/master","pushedAt":"2024-04-23T20:28:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/aliases: expose Enabled\n\nThe predicate that determines whether the type checker\ncreates types.Alias nodes is complex: it depends on an\nenvironment variable (GODEBUG) that is somewhat tricky\nto parse correctly, since it is a rightmost-wins list.\n\nCritically, however, its default value is a function of\nthe go directive in the application's go.mod file, which\nis inaccessible to logic in x/tools (per-file build tags\ncan detect the toolchain version, but not the go.mod version).\nEqually critically, the current effective value of the\ngotypesalias variable changes when os.Setenv(GODEBUG) is\ncalled, which happens in tests, and there is no way to\ndetect those events; therefore any attempt to cache the\nvalue is wrong.\n\nThis change exposes a simplified version of the Enabled\nfunction from aliases, which always computes the ground\ntruth by invoking the type checker, regardless of cost.\nIt also adds an 'enabled' parameter to NewAlias so that\ncallers can amortize this cost.\n\nAlso, various minor cleanups related to aliases.\n\nUpdates golang/go#64581\n\nChange-Id: If926edefb8e1c1f63c17e4fad0a808e27bac6d5b\nReviewed-on: https://go-review.googlesource.com/c/tools/+/580455\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/aliases: expose Enabled"}},{"before":"e8c9d819d87543cd5ae9a9d6c84ad4efef39db5f","after":"a363d11f520e51f57e123b358307fd91ce388c84","ref":"refs/heads/master","pushedAt":"2024-04-23T15:10:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types/typeutil: replace interface{} with any (cleanup)\n\nChange-Id: If5b8faffbf4a60338bab4eb3c5fbcc6a3c3c3952\nReviewed-on: https://go-review.googlesource.com/c/tools/+/581116\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"go/types/typeutil: replace interface{} with any (cleanup)"}},{"before":"97ea8165d8c479957ee08ab3b5bfb971b990874e","after":"e8c9d819d87543cd5ae9a9d6c84ad4efef39db5f","ref":"refs/heads/master","pushedAt":"2024-04-23T14:53:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/analysis/passes/tests: Use ReportRangef to refactor some code in checkTest\n\nUse ReportRangef to replace the original Reportf\nto try to implement two TODOs.\n\nChange-Id: I9dfc0f47881d7638e460164a9dc5573394b92eee\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579615\nReviewed-by: Robert Findley \nAuto-Submit: Robert Findley \nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/analysis/passes/tests: Use ReportRangef to refactor some code in c…"}},{"before":"8db95b70d227d60f7c6cc71a1244f6667a721eb3","after":"97ea8165d8c479957ee08ab3b5bfb971b990874e","ref":"refs/heads/master","pushedAt":"2024-04-22T15:08:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix some typos in comments\n\nChange-Id: I5d5f6cc4a6984b8577e8178082bc60dfe08107b6\nGitHub-Last-Rev: 16ede6bf755f9f89950e27505d10fdbca2a9e562\nGitHub-Pull-Request: golang/tools#490\nReviewed-on: https://go-review.googlesource.com/c/tools/+/580156\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam \nAuto-Submit: Ian Lance Taylor ","shortMessageHtmlLink":"all: fix some typos in comments"}},{"before":"daf94608b5e2caf763ba634b84e7a5ba7970e155","after":"8db95b70d227d60f7c6cc71a1244f6667a721eb3","ref":"refs/heads/master","pushedAt":"2024-04-22T14:15:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: check the comment range before emiting semantic tokens\n\nChange-Id: If300720c92bfb1ac63b395efc2419f1f1c8bed8f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/580595\nReviewed-by: Alan Donovan \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/golang: check the comment range before emiting semanti…"}},{"before":"618670db50afe87b1d1755edd2ae2754242d686b","after":"daf94608b5e2caf763ba634b84e7a5ba7970e155","ref":"refs/heads/master","pushedAt":"2024-04-19T17:44:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"Revert \"gopls/internal/test/integration/misc: reenable staticcheck test\"\n\nThis reverts commit 618670db50afe87b1d1755edd2ae2754242d686b.\n\nReason for revert: The test does not in fact pass, but this was obscured by a bug (?) in the godebug machinery, which uses a default value poked into the executable at link-time of \"...gotypesalias=0...\",\nwhich means the default value is not \"on\", as we thought when we changed the interpretation of unset to mean \"on\".\n\nChange-Id: Ib45b230a80d8b52a9d69db56025dae34add29fb8\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579757\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"Revert \"gopls/internal/test/integration/misc: reenable staticcheck test\""}},{"before":"2debfbeabeb17bde7da3503ad2e35aee2918ee3d","after":"618670db50afe87b1d1755edd2ae2754242d686b","ref":"refs/heads/master","pushedAt":"2024-04-19T12:38:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/test/integration/misc: reenable staticcheck test\n\nThis test reenables the staticcheck test, which now passes\nwith gotypesalias={,0,1}. (Staticcheck may yet need work, but\nthat isn't evident to our tests.)\n\nUpdates golang/go#64581\n\nChange-Id: I1c8acca2c6b7d16e551a5c8a68be564254713d0d\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579756\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/test/integration/misc: reenable staticcheck test"}},{"before":"c17402c833b67bd88d40671a1ef09ec88dbe5c19","after":"2debfbeabeb17bde7da3503ad2e35aee2918ee3d","ref":"refs/heads/master","pushedAt":"2024-04-17T23:45:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/testfiles: add a helper package for test files\n\nAdds a new package testfiles to help write tests around go files\nand directories. These are especially helpful when dealing with\ngo.mod files.\n\nAdds a new CopyTestFiles function that copies a directory and\nremoves the \".test\" file extension, e.g. \"go.mod.test\" becomes\n\"go.mod\". This allows for easily creating analysistests\nwith go.mod files. This change also adds a new TestDir helper\nto extract to a temporary directory.\n\nConsolidates txtar usage around ExtractTxtar, which writes a\ntxtar archive to a directory, and adds a convenience helper\nTestTxtar that extracts a txtar at a path to a temporary\ndirectory.\n\nUpdates golang/go#61336\nUpdates golang/go#53063\nUpdates golang/go#46041\nUpdates golang/go#37054\n\nChange-Id: I09210f751bbc6ac3f01c34fba22b7e8fa1ddf93f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/577995\nReviewed-by: Alan Donovan \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/testfiles: add a helper package for test files"}},{"before":"ee61fb0cbd3028fb3de7a23cd0bffed3ec8b716d","after":"c17402c833b67bd88d40671a1ef09ec88dbe5c19","ref":"refs/heads/master","pushedAt":"2024-04-17T18:10:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: fix a couple places where temporary files are not removed\n\nFix two places where gopls fails to clean up temporary files:\n- In telemetry tests, the deferred cleanup was not run after os.Exit.\n- In the GC details codelens, a persistent GC details directory is\n assumed; just use a temp directory instead.\n\nChange-Id: Icef5a4b612ac1727fee7d2c65e99a90f73123081\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579755\nReviewed-by: Alan Donovan \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls: fix a couple places where temporary files are not removed"}},{"before":"37355859600fbb57278e22d677be4c6b6cf7b1a8","after":"ee61fb0cbd3028fb3de7a23cd0bffed3ec8b716d","ref":"refs/heads/master","pushedAt":"2024-04-17T17:31:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/packages: fix issue number typo in TestIssue37629\n\nI had written 37529 but the issue it was fixing was actually 37629.\nFix that in the test name and comments.\n\nFor golang/go#37629\n\nChange-Id: Id3798423b9039e9a330d00c32f600181e254f757\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579715\nReviewed-by: Sam Thanawalla \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/packages: fix issue number typo in TestIssue37629"}},{"before":"f4888c511831729447174e4eeff4a371d9481288","after":"37355859600fbb57278e22d677be4c6b6cf7b1a8","ref":"refs/heads/master","pushedAt":"2024-04-17T15:37:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/settings: deprecate \"allowImplicitNetworkAccess\"\n\nThis setting changes the behavior of gopls in fundamental low-level\nways, and therefore is severely under-tested and now worth maintaining.\nGopls should make accurate decisions about whether to allow network\naccess for commands.\n\nFixes golang/go#66860\n\nChange-Id: Ia2f58bf146fc6bd37d769b65fc227cb2d0027032\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579437\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"gopls/internal/settings: deprecate \"allowImplicitNetworkAccess\""}},{"before":"d857e8544b9ca13b48482501f558e36389bff4ae","after":"f4888c511831729447174e4eeff4a371d9481288","ref":"refs/heads/master","pushedAt":"2024-04-17T15:14:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/settings: remove support for \"allowModfileModifications\"\n\nThat no tests fail when this setting is removed is evidence enough that\nit is unsupported. Additionally, this was one of the final pins holding\ntogether some of the unnecessary complexity of the gocommand package,\nwhich subsequent CLs will untangle.\n\nFixes golang/go#65546\n\nChange-Id: I8efececfd743d898c5f72c6a2d2a416e023ee3bc\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579435\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/settings: remove support for \"allowModfileModifications\""}},{"before":"3f74dc588604cd149e78e4724603acca94f23dbd","after":"d857e8544b9ca13b48482501f558e36389bff4ae","ref":"refs/heads/master","pushedAt":"2024-04-17T14:59:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/settings: enable semantic tokens by default\n\nWhether or not semantic tokens are enabled should be a client-side\nsetting. Clients that don't want semantic tokens should not ask for\nthem, and if clients send textDocument/semanticTokens requests, gopls\nshould handle them by default. Unfortunately, as described in\ngolang/vscode-go#3338, this is not how semantic tokens were configured\nin the past.\n\nThis CL changes the default value of the \"semanticTokens\" setting to\ntrue. We should not release a gopls version with this change until\naddressing golang/vscode-go#3338, but by making this change in master\nnow it is easier to test the fix in vscode-go.\n\nFor golang/vscode-go#3338\n\nChange-Id: I05d7084436cd4dfe312460cfe08e3b1777f190ed\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579337\nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/settings: enable semantic tokens by default"}},{"before":"e7165990ca6335ec420277a437b82441e7aff013","after":"3f74dc588604cd149e78e4724603acca94f23dbd","ref":"refs/heads/master","pushedAt":"2024-04-16T19:54:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/settings: remove experiments\n\nRemove the concept of \"experiments\" from gopls settings and testing. In\nthe past, this was a way for us to selectively enable features in the VS\nCode nightly build, but we have since switched to a model where we cut\nearlier prereleases and endeavor to have more prerelease testing.\n\nFixes golang/go#65548\n\nChange-Id: I64d739dd4b4899c19ce5cd0c3da45e498e9ae417\nReviewed-on: https://go-review.googlesource.com/c/tools/+/579395\nAuto-Submit: Robert Findley \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/settings: remove experiments"}},{"before":"7c7d7dbaa51d0928605d6649426dac1a9ecba646","after":"e7165990ca6335ec420277a437b82441e7aff013","ref":"refs/heads/master","pushedAt":"2024-04-16T16:30:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/goimports: support workspace vendoring\n\nFixes golang/go#65744\n\nThis also fixes gopls imports.\n\nChange-Id: I8a3beff6c96ff27d7622c1315e3f2dffc83194a3\nGitHub-Last-Rev: d199d2c9cca957dc69de1bb775f254d2bac762f5\nGitHub-Pull-Request: golang/tools#485\nReviewed-on: https://go-review.googlesource.com/c/tools/+/572675\nReviewed-by: Peter Weinberger \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/goimports: support workspace vendoring"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQZxGrgA","startCursor":null,"endCursor":null}},"title":"Activity · golang/tools"}