Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golangci/golangci-lint-action
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.0
Choose a base ref
...
head repository: golangci/golangci-lint-action
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.5.0
Choose a head ref

Commits on Jan 30, 2023

  1. Copy the full SHA
    c5c27db View commit details
  2. Copy the full SHA
    1aee3f9 View commit details
  3. Copy the full SHA
    a2a2520 View commit details
  4. Copy the full SHA
    650217c View commit details
  5. Copy the full SHA
    d36410f View commit details

Commits on Feb 6, 2023

  1. Copy the full SHA
    76503fd View commit details
  2. Copy the full SHA
    5782ee8 View commit details
  3. Copy the full SHA
    97c6242 View commit details
  4. Copy the full SHA
    6a290f7 View commit details

Commits on Feb 8, 2023

  1. Copy the full SHA
    a904d1d View commit details

Commits on Feb 13, 2023

  1. Copy the full SHA
    7b2a3f3 View commit details
  2. Copy the full SHA
    ac77de6 View commit details
  3. Copy the full SHA
    4e6daa7 View commit details
  4. Copy the full SHA
    8c2f4f9 View commit details
  5. build(deps): bump @actions/cache from 3.1.2 to 3.1.3 (#672)

    Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
    dependabot[bot] and ldez authored Feb 13, 2023
    Copy the full SHA
    419d091 View commit details

Commits on Feb 20, 2023

  1. Copy the full SHA
    1ea2010 View commit details
  2. Copy the full SHA
    01dfc86 View commit details
  3. Copy the full SHA
    12dfd24 View commit details
  4. Copy the full SHA
    fdf641b View commit details

Commits on Feb 24, 2023

  1. chore: fix CI for pull request

    ldez committed Feb 24, 2023
    Copy the full SHA
    aa94bc7 View commit details

Commits on Feb 27, 2023

  1. Copy the full SHA
    a2dc749 View commit details
  2. Copy the full SHA
    8b76d97 View commit details
  3. Copy the full SHA
    61703f1 View commit details
  4. Copy the full SHA
    bf4120f View commit details
  5. build(deps): bump @actions/cache from 3.1.3 to 3.1.4 (#686)

    Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
    dependabot[bot] and ldez authored Feb 27, 2023
    Copy the full SHA
    e92337f View commit details

Commits on Mar 6, 2023

  1. Copy the full SHA
    d6d0cce View commit details
  2. Copy the full SHA
    5077eeb View commit details
  3. Copy the full SHA
    7cd2f03 View commit details
  4. Copy the full SHA
    92ba55c View commit details

Commits on Mar 13, 2023

  1. Copy the full SHA
    464d9fd View commit details
  2. Copy the full SHA
    30dacc8 View commit details
  3. Copy the full SHA
    4593d99 View commit details

Commits on Mar 20, 2023

  1. Copy the full SHA
    39b10dd View commit details
  2. Copy the full SHA
    7122616 View commit details
  3. Copy the full SHA
    ea65405 View commit details
  4. build(deps): bump @actions/http-client from 2.0.1 to 2.1.0 (#697)

    Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
    dependabot[bot] and ldez authored Mar 20, 2023
    Copy the full SHA
    8c99775 View commit details
  5. Copy the full SHA
    3fc1207 View commit details
  6. build(deps): bump @actions/cache from 3.1.4 to 3.2.1 (#698)

    Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
    dependabot[bot] and ldez authored Mar 20, 2023
    Copy the full SHA
    0fd2014 View commit details

Commits on Mar 27, 2023

  1. Copy the full SHA
    76eaf57 View commit details
  2. Copy the full SHA
    ed929be View commit details
  3. Copy the full SHA
    db0ea3f View commit details
  4. Copy the full SHA
    2fdccc4 View commit details
  5. Copy the full SHA
    e1c0a05 View commit details

Commits on Apr 3, 2023

  1. Copy the full SHA
    b26535e View commit details
  2. Copy the full SHA
    7261544 View commit details
  3. Copy the full SHA
    7641ddf View commit details
  4. Copy the full SHA
    32a0469 View commit details

Commits on Apr 10, 2023

  1. Copy the full SHA
    579a4e6 View commit details
  2. Copy the full SHA
    c7b6fc9 View commit details
  3. Copy the full SHA
    f678157 View commit details
Showing with 6,507 additions and 9,080 deletions.
  1. +13 −5 .github/workflows/test.yml
  2. +8 −6 README.md
  3. +2,896 −4,185 dist/post_run/index.js
  4. +2,896 −4,185 dist/run/index.js
  5. +453 −473 package-lock.json
  6. +12 −12 package.json
  7. +68 −63 sample-go-mod/go.mod
  8. +161 −151 sample-go-mod/go.sum
18 changes: 13 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -10,10 +10,14 @@ jobs:
build: # make sure build/ci work properly
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- if: ${{ !(github.event_name == 'pull_request' && (github.event.pull_request.user.id == 49699333 || contains(github.event.pull_request.labels.*.name, 'dependencies'))) }}
uses: actions/checkout@v3
- if: github.event_name == 'pull_request' && (github.event.pull_request.user.id == 49699333 || contains(github.event.pull_request.labels.*.name, 'dependencies'))
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref }}

- run: |
npm install
npm run all
@@ -48,15 +52,17 @@ jobs:
version:
- ""
- "latest"
- "v1.49"
- "v1.49.0"
- "v1.51"
- "v1.51.2"
runs-on: ${{ matrix.os }}
permissions:
contents: read
pull-requests: read
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
- uses: actions/setup-go@v4
with:
cache: false # setup-go v4 caches by default
- uses: ./
with:
version: ${{ matrix.version }}
@@ -76,7 +82,9 @@ jobs:
contents: read
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
- uses: actions/setup-go@v4
with:
cache: false # setup-go v4 caches by default
- uses: ./
with:
working-directory: sample-go-mod
14 changes: 8 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -38,9 +38,10 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v3
- uses: actions/setup-go@v4
with:
go-version: 1.17
go-version: '1.17'
cache: false
- uses: actions/checkout@v3
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
@@ -98,10 +99,11 @@ jobs:
name: lint
runs-on: ${{ matrix.os }}
steps:
- uses: actions/setup-go@v3
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: ${{ matrix.go }}
- uses: actions/checkout@v3
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
@@ -167,9 +169,9 @@ Inside our action we perform 3 steps:
### Caching internals

1. We save and restore the following directories: `~/.cache/golangci-lint`, `~/.cache/go-build`, `~/go/pkg`.
2. The primary caching key looks like `golangci-lint.cache-{platform-arch}-{interval_number}-{go.mod_hash}`. Interval number ensures that we periodically invalidate
2. The primary caching key looks like `golangci-lint.cache-{interval_number}-{go.mod_hash}`. Interval number ensures that we periodically invalidate
our cache (every 7 days). `go.mod` hash ensures that we invalidate the cache early - as soon as dependencies have changed.
3. We use [restore keys](https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows#matching-a-cache-key): `golangci-lint.cache-{interval_number}-`, `golangci-lint.cache-`. GitHub matches keys by prefix if we have no exact match for the primary cache.
3. We use [restore keys](https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows#matching-a-cache-key): `golangci-lint.cache-{interval_number}-`. GitHub matches keys by prefix if we have no exact match for the primary cache.

This scheme is basic and needs improvements. Pull requests and ideas are welcome.

Loading