Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase goconst #1009

Closed
3 tasks done
SuperQ opened this issue Mar 31, 2020 · 5 comments
Closed
3 tasks done

Rebase goconst #1009

SuperQ opened this issue Mar 31, 2020 · 5 comments
Labels
dependencies Relates to an upstream dependency forks We shall not use forks of linters

Comments

@SuperQ
Copy link

SuperQ commented Mar 31, 2020

Thank you for creating the issue!

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

Please include the following information:

$ golangci-lint --version
golangci-lint has version 1.24.0 built from 6fd4383 on 2020-03-15T11:38:02Z

It would be good to rebase https://github.com/golangci/goconst to pick up the commit in the upstream master that matches function params.

@ernado ernado added the dependencies Relates to an upstream dependency label Apr 21, 2020
@gonzaloserrano
Copy link

Also interested in this.

@SVilgelm
Copy link
Member

SVilgelm commented Sep 7, 2020

It would be better to get rid of the golangci/goconst repo and switch to the main goconst, but it requires to move some code from golangci/goconst to the golangci-lint repo

@gonzaloserrano
Copy link

Sorry, I'm kind of new to golangci-lint internals. Since golangci/goconst has diverged from the original goconst (it's 2 commits ahead and 1 behind it), what's needed here? Rebase golangci/goconst and move the code to this repo?

@SVilgelm
Copy link
Member

SVilgelm commented Sep 8, 2020

So, the golangci/goconst contains some code that add a support of goconst (Run function). I think it's better to move the code that has been added to the golangci-lint repo and have a direct import of goconst module. So we will be able to update the goconst if needed.

@ldez ldez added the forks We shall not use forks of linters label Feb 13, 2021
@ldez
Copy link
Member

ldez commented Feb 13, 2021

Closed by #1500

@ldez ldez closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency forks We shall not use forks of linters
Projects
None yet
Development

No branches or pull requests

5 participants