Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update godot to 1.3.0 #1498

Merged
merged 1 commit into from Nov 10, 2020
Merged

Update godot to 1.3.0 #1498

merged 1 commit into from Nov 10, 2020

Conversation

tetafro
Copy link

@tetafro tetafro commented Nov 7, 2020

Update for godot linter. Now it can check any comment, not only top-level comments. Also it can check capital letter at the beginning of sentences.

There is a breaking change in config. I'm not sure what's the right way to introduce it. I removed old setting check-all from config example, but didn't remove it from GodotSettings struct to avoid breaking existing configs. Old setting check-all is silently translated to new scope.

Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernado ernado merged commit df2e9e2 into golangci:master Nov 10, 2020
@golangci-automator
Copy link

Hey, @tetafro — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@ldez ldez added the linter: update version Update version of linter label Dec 7, 2020
@ldez ldez added this to the v1.33 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants