Parallel test linter

[kunwardeep]

This PR adds the paralleltest linter. This linter checks for incorrect usage of t.Parallel() in the tests. If the liner is enabled it will complain about each and every place we can use t.Parallel(). It also ensures that if we are using a range over test cases, we reinitialised the test case variable (More Info)

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[CLAassistant]

All committers have signed the CLA.

[tetafro]

JFYI there is scopelint that checks incorrect usage of loop variables, but not only in tests.

[tetafro]

And don't forget to squash commits ;)

[tetafro]

LGTM

[kunwardeep]

Umm, how do get it merged? Is there a separate process for that?

[bombsimon]

Umm, how do get it merged? Is there a separate process for that?

Nope, nothing else. But probably good to have a few more approvals when merging a new linter.

[bombsimon]

LGTM

[golangci-automator]

Hey, @kunwardeep — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

[wyardley]

I don't see this in https://golangci-lint.run/usage/linters/ yet -- does it need to be added there?

[bombsimon]

Not manually, but the make targe to re-generate the documentation and commit those changes needs to be done. I think it should be made automatically once a week with GitHub Actions so it will end up there.

[wyardley]

@bombsimon thanks! Assumed it was automagic, just wanted to confirm (didn't know there was a delay).

[kunwardeep]

yeah.. I thought so too, but after reading this, this looks like a manual step. so here is another PR- https://github.com/golangci/golangci-lint/pull/1526/files