{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":474553936,"defaultBranch":"master","name":"go","ownerLogin":"golangclub","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-03-27T06:25:56.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/72120059?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1648362358.4019132","currentOid":""},"activityList":{"items":[{"before":"beaf7f3282c2548267d3c894417cc4ecacc5d575","after":"b788e91badd523e5bb0fc8d50cd76b8ae04ffb20","ref":"refs/heads/master","pushedAt":"2024-06-12T00:17:27.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"os: always return syscall.ECHILD from Wait for done process\n\nFor processes that don't exist at lookup time, CL 570036 and CL 588675\nmake Wait return unconditionally return ErrProcessDone when using pidfd,\nrather than attempting to make a wait system call.\n\nThis is consistent with Signal/Kill, but inconsistent with the previous\nbehavior of Wait, which would pass through the kernel error,\nsyscall.ECHILD.\n\nSwitch the ErrProcessDone case to return syscall.ECHILD instead for\nconsistency with previous behavior.\n\nThat said, I do think a future release should consider changing ECHILD\nto ErrProcessDone in all cases (including when making an actual wait\nsystem call) for better consistency with Signal/Kill/FindProcess.\n\nFixes #67926.\n\nCq-Include-Trybots: luci.golang.try:gotip-darwin-amd64_14,gotip-solaris-amd64,gotip-openbsd-amd64\nChange-Id: I1f688a5751d0f3aecea99c3a5b35c7894cfc2beb\nReviewed-on: https://go-review.googlesource.com/c/go/+/591816\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Kirill Kolyshkin \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"os: always return syscall.ECHILD from Wait for done process"}},{"before":"c83b1a7013784098c2061ae7be832b2ab7241424","after":"beaf7f3282c2548267d3c894417cc4ecacc5d575","ref":"refs/heads/master","pushedAt":"2024-06-11T04:17:54.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"os: overhaul handling of PID vs pidfd within Process\n\nThere are several issues with pidfd handling today:\n\n* The zero value of a Process makes the handle field appear valid, so\n methods attempt to use it as a pidfd rather than falling back to the\n PID as they should (#67634).\n\n* If a process doesn't exist, FindProcess returns a Process with Pid ==\n -2, which is not a compatible change (#67640).\n\n* pidfd close is racy as-is. A Release call or successful Wait will\n clear the handle field and close the pidfd. However, a concurrent call\n may have already loaded the handle field and could then proceed to use\n the closed FD (which could have been reopened as a different pidfd,\n targeting a different process) (#67641).\n\nThis CL performs multiple structural changes to the internals of\nProcess.\n\nFirst and foremost, each method is refactored to clearly select either\npidfd or raw pid mode. Previously, raw pid mode was structured as a\nfallback when pidfd mode is unavailable. This works fine, but it does\nnot make it clear that a given Process object either always uses pidfd\nor always uses raw pid. Since each mode needs to handle different race\nconditions, it helps to make it clear that we can't switch between modes\nwithin a single Process object.\n\nSecond, pidfd close safety is handled by reference counting uses of the\nFD. The last user of the FD will close the FD. For example, this means\nthat with concurrent Release and Signal, the Signal call may be the one\nto close the FD. This is the bulk of this CL, though I find the end\nresult makes the overall implementation easier to reason about.\n\nThird, the PID path handles a similar race condtion between Wait and\nKill: Wait frees the PID value in the kernel, which could be reallocated\ncausing Kill to target the wrong process. This is handled with a done\nflag and a mutex. The done flag now shares the same state field used for\nthe handle.\n\nSimilarly, the Windows implementation reuses all of the handle reference\ncounting that Linux uses. This means the implementations more\nconsistent, and make Windows safe against the same handle reuse\nproblems. (Though I am unsure if Windows ever reuses handles).\n\nWait has a slight behavior change on Windows: previously Wait after\nRelease or an earlier Wait would hang indefinitely (WaitForSingleObject\non syscall.InvalidHandle waits indefinitely). Now it returns the same\nerrors as Linux (EINVAL and ErrProcessDone, respectively).\n\nSimilarly, Release on Windows no longer returns close errors, as it may\nnot actually be the place where the close occurs.\n\nFixes #67634.\nFixes #67640.\nFixes #67641.\nUpdates #67642.\n\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest\nChange-Id: I2ad998f7b67d32031e6f870e8533dbd55d3c3d10\nReviewed-on: https://go-review.googlesource.com/c/go/+/588675\nReviewed-by: Austin Clements \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"os: overhaul handling of PID vs pidfd within Process"}},{"before":"f7c330eac7777612574d8a1652fd415391f6095e","after":"c83b1a7013784098c2061ae7be832b2ab7241424","ref":"refs/heads/master","pushedAt":"2024-06-07T23:34:18.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"sync: include links to the Go memory model in package documentation\n\nThe lack of links to https://go.dev/ref/mem in the sync package\ndocumentation makes it difficult to read for people who have no previous\nknowledge of that page. This PR includes the links where needed.\n\nFixes #67891\n\nChange-Id: I0e1344cc6d7b702f4cb2e55fe0fcee3eb089391a\nGitHub-Last-Rev: 427cf58aaeaae2e4b060248dd592e5fe8c6b7df4\nGitHub-Pull-Request: golang/go#67892\nReviewed-on: https://go-review.googlesource.com/c/go/+/591395\nReviewed-by: Michael Knyszek \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sync: include links to the Go memory model in package documentation"}},{"before":"45967bb18e04fa6dc62c2786c87ce120443c64f6","after":"f7c330eac7777612574d8a1652fd415391f6095e","ref":"refs/heads/master","pushedAt":"2024-06-07T06:24:54.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"runtime: add a note on SetFinalizer doc about method receiver\n\nA method receiver can be collected during the execution of that method.\nThis does make sense when thinking about how the GC would work, but\nalso seems not very obvious, so a point in the docs can increase the\nchance of avoiding issues caused by missing KeepAlive of method\nreceivers.\n\nChange-Id: I6817237dd022b5729dbdcda1b9f70c7059605575\nGitHub-Last-Rev: 878bf3fde7b4ed66be0302ffdd5e704b4cd70a6c\nGitHub-Pull-Request: golang/go#67777\nReviewed-on: https://go-review.googlesource.com/c/go/+/589735\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"runtime: add a note on SetFinalizer doc about method receiver"}},{"before":"1b07b774c06ba0a0baf0a19324ab76ace5741305","after":"45967bb18e04fa6dc62c2786c87ce120443c64f6","ref":"refs/heads/master","pushedAt":"2024-06-06T14:55:11.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"runtime: soften up the GCTestIsReachable test a bit\n\nThis test can fail due to objects being incorrectly retained due\nto conservative scanning. Allow a bit of slop (1 accidentally\nretained object) to prevent flaky failures.\n\nFixes #67204\n\n\"fixes\" is a bit too strong a word. More like, hopefully reduces\nthe false positive rate to something approaching 0.\n\nChange-Id: I09984f0cce50d8209aef19f3d89b0e295c86f8d1\nReviewed-on: https://go-review.googlesource.com/c/go/+/590615\nReviewed-by: Keith Randall \nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"runtime: soften up the GCTestIsReachable test a bit"}},{"before":"9b43bfbc51c469ec13fca24960834a75b2bf66eb","after":"1b07b774c06ba0a0baf0a19324ab76ace5741305","ref":"refs/heads/master","pushedAt":"2024-06-05T00:40:03.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"doc: document \"range-over-func\" language change in release notes\n\nFor #65614.\n\nChange-Id: Idbbcb6eb57b7294d52b174c1aba74ca7aa1b8efd\nReviewed-on: https://go-review.googlesource.com/c/go/+/590616\nReviewed-by: Ian Lance Taylor \nReviewed-by: Robert Griesemer \nTryBot-Bypass: Robert Griesemer ","shortMessageHtmlLink":"doc: document \"range-over-func\" language change in release notes"}},{"before":"c26be72d686005167516333bf3dc2a52df3e2961","after":"9b43bfbc51c469ec13fca24960834a75b2bf66eb","ref":"refs/heads/master","pushedAt":"2024-06-01T09:44:42.000Z","pushType":"push","commitsCount":31,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"cmd/vendor: update github.com/google/pprof\n\nBrings in the latest github.com/google/pprof.\n\nFixes #67626\n\nChange-Id: Id8faef20f0a9bf81dd117110bf540aca852db6be\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/go/+/588655\nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/vendor: update github.com/google/pprof"}},{"before":"377646589d5fb0224014683e0d1f1db35e60c3ac","after":"c26be72d686005167516333bf3dc2a52df3e2961","ref":"refs/heads/master","pushedAt":"2024-05-29T01:19:11.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"archive/zip: fix UncompressedSize godoc\n\nChange-Id: I0c142eb18af7b03759041e894bbce0f365ea9d7e\nReviewed-on: https://go-review.googlesource.com/c/go/+/588116\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"archive/zip: fix UncompressedSize godoc"}},{"before":"2fe2e4d593aaa01ca00ad861808846a2b3328b05","after":"377646589d5fb0224014683e0d1f1db35e60c3ac","ref":"refs/heads/master","pushedAt":"2024-05-26T01:16:41.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"text/template: clarify error when too few or too many return values\n\nPrior to CL 561115, calling a function without any return values would\nprint \"function called with 0 args; should be 1 or 2\". Afterwards, the\nerror message became \"too many return values\".\n\nKeep the improvement of referring to return values rather than args,\nand bring back clarity about their actual and permitted numbers.\n\nChange-Id: I2c014e4633208cc7052fac265a995a8f2fe68151\nReviewed-on: https://go-review.googlesource.com/c/go/+/588355\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"text/template: clarify error when too few or too many return values"}},{"before":"4cac885741b845bd7f4aaad5bc9844b44eb23136","after":"2fe2e4d593aaa01ca00ad861808846a2b3328b05","ref":"refs/heads/master","pushedAt":"2024-05-24T01:07:11.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"go/types, types2: document why Unalias is not needed in some places\n\nDocumentation change only.\n\nFor #67547.\n\nChange-Id: I0da480299c33239bcd1e059f8b9c6d48d8f26609\nReviewed-on: https://go-review.googlesource.com/c/go/+/587820\nTryBot-Bypass: Robert Griesemer \nReviewed-by: Robert Griesemer \nReviewed-by: Robert Findley \nAuto-Submit: Robert Griesemer ","shortMessageHtmlLink":"go/types, types2: document why Unalias is not needed in some places"}},{"before":"bf0bbd5360bb4d3ecb03b274fbb8419c69e54c28","after":"4cac885741b845bd7f4aaad5bc9844b44eb23136","ref":"refs/heads/master","pushedAt":"2024-05-23T01:22:13.000Z","pushType":"push","commitsCount":64,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"all: document legacy //go:linkname for modules with ≥200 dependents\n\nIgnored these linknames which have not worked for a while:\n\ngithub.com/xtls/xray-core:\n\tcontext.newCancelCtx removed in CL 463999 (Feb 2023)\n\ngithub.com/u-root/u-root:\n\tfuncPC removed in CL 513837 (Jul 2023)\n\ntinygo.org/x/drivers:\n\tnet.useNetdev never existed\n\nFor #67401.\n\nChange-Id: I9293f4ef197bb5552b431de8939fa94988a060ce\nReviewed-on: https://go-review.googlesource.com/c/go/+/587576\nAuto-Submit: Russ Cox \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"all: document legacy //go:linkname for modules with ≥200 dependents"}},{"before":"22344e11f27d9667e7bbb6209df59e9a9e976d91","after":"bf0bbd5360bb4d3ecb03b274fbb8419c69e54c28","ref":"refs/heads/master","pushedAt":"2024-05-22T06:32:29.000Z","pushType":"push","commitsCount":28,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"math/rand/v2: drop pointer receiver on zero-width type\n\nJust a cleanup.\n\nChange-Id: Ibeb2c7d447c793086280e612fe5f0f7eeb863f71\nReviewed-on: https://go-review.googlesource.com/c/go/+/582875\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Damien Neil \nReviewed-by: Jorropo ","shortMessageHtmlLink":"math/rand/v2: drop pointer receiver on zero-width type"}},{"before":"e3d87d19320001e6081449550292d76ef660ab03","after":"22344e11f27d9667e7bbb6209df59e9a9e976d91","ref":"refs/heads/master","pushedAt":"2024-05-21T01:14:31.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"cmd/compile: add structs.HostLayout\n\nThis is for the proposal, plus a few bug fixes\nthat would/will be necessary when this is put into\nactual use.\n\nFixes #66408.\nUpdates #63131.\n\nChange-Id: I3a66e09d707dd579c59f155e7f53367f41214c30\nReviewed-on: https://go-review.googlesource.com/c/go/+/578355\nReviewed-by: Austin Clements \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: David Chase ","shortMessageHtmlLink":"cmd/compile: add structs.HostLayout"}},{"before":"69105d79efeb4d369f6de4962b1d871c80a3db7d","after":"e3d87d19320001e6081449550292d76ef660ab03","ref":"refs/heads/master","pushedAt":"2024-05-20T01:12:58.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"hash: use more internal/byteorder functions to simplify the code\n\nA follow-up for the CL 585015.\n\nChange-Id: I412f33f1d75abe1446cb3fd742d44d3cb4350380\nGitHub-Last-Rev: 554ace757cc75389e7a3c441d3a60cfa85c815a5\nGitHub-Pull-Request: golang/go#67476\nReviewed-on: https://go-review.googlesource.com/c/go/+/586240\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall \nAuto-Submit: Ian Lance Taylor \nAuto-Submit: Dmitri Shuralyov \nCommit-Queue: Ian Lance Taylor ","shortMessageHtmlLink":"hash: use more internal/byteorder functions to simplify the code"}},{"before":"722d59436bc5881914619d2b95c9d01a46036428","after":"69105d79efeb4d369f6de4962b1d871c80a3db7d","ref":"refs/heads/master","pushedAt":"2024-05-17T00:45:54.000Z","pushType":"push","commitsCount":22,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"cmd/go: unexport loadImport\n\nComplete a TODO.\n\nChange-Id: I39869df4d95a5a5f6019e281719b942fbf4ba7db\nGitHub-Last-Rev: c664b5332e4f0afc84ae9bf1f91c0664903ebb7e\nGitHub-Pull-Request: golang/go#67091\nReviewed-on: https://go-review.googlesource.com/c/go/+/581939\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/go: unexport loadImport"}},{"before":"8623c0ba95f01387c2d705349722b5fcb2b3e77d","after":"722d59436bc5881914619d2b95c9d01a46036428","ref":"refs/heads/master","pushedAt":"2024-05-16T03:31:48.000Z","pushType":"push","commitsCount":41,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"crypto/x509: add text and binary marshal methods to OID\n\nFixes #66249\n\nChange-Id: I5973a19a087a35ad951e8a220d3e6e4456c7577f\nGitHub-Last-Rev: 921ca8bd0c08687bb727dbfb0890c3355eebe95b\nGitHub-Pull-Request: golang/go#66599\nReviewed-on: https://go-review.googlesource.com/c/go/+/575295\nReviewed-by: Rob Pike \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Roland Shoemaker \nAuto-Submit: Roland Shoemaker ","shortMessageHtmlLink":"crypto/x509: add text and binary marshal methods to OID"}},{"before":"74a49188d300076d6fc6747ea7678d327c5645a1","after":"8623c0ba95f01387c2d705349722b5fcb2b3e77d","ref":"refs/heads/master","pushedAt":"2024-05-14T08:14:46.000Z","pushType":"push","commitsCount":25,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"internal/chacha8rand: use internal/byteorder\n\nChange-Id: Ia5bcaba47da949583a720ca3506d6bd9e3794824\nGitHub-Last-Rev: 1ed3dad2bf43df5526572f7fdc4c3b02ab977a01\nGitHub-Pull-Request: golang/go#67320\nReviewed-on: https://go-review.googlesource.com/c/go/+/584996\nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/chacha8rand: use internal/byteorder"}},{"before":"1259a30a588392e6a1efbed9e0c7d893c72187fa","after":"74a49188d300076d6fc6747ea7678d327c5645a1","ref":"refs/heads/master","pushedAt":"2024-05-11T00:59:26.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"cmd/go/testdata/script: disable build_plugin_reproducible on darwin\n\nIt's broken with the latest XCode versions, and is also already disabled\non darwin builders. Disable the test to get go test cmd/go working on\nlocal builds again.\n\nFor #64947\n\nChange-Id: I5a4b46cf23cbe887df4903f90b54cd2225f51233\nReviewed-on: https://go-review.googlesource.com/c/go/+/584937\nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/go/testdata/script: disable build_plugin_reproducible on darwin"}},{"before":"6584fe8195a1a0afb65ffbea11a2a4fe760a2abd","after":"1259a30a588392e6a1efbed9e0c7d893c72187fa","ref":"refs/heads/master","pushedAt":"2024-05-10T07:40:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"os: change ioutil-test to os-test in test\n\nChange-Id: I8c5c0831b94261c5880ca22b7ea52cce034d88f1\nGitHub-Last-Rev: 5fd119d4e8e5f98690afb2d966c07aea19415db0\nGitHub-Pull-Request: golang/go#67248\nReviewed-on: https://go-review.googlesource.com/c/go/+/583876\nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"os: change ioutil-test to os-test in test"}},{"before":"49eedfb4d07ab6c0d62041ba722dfe81e73d92ce","after":"6584fe8195a1a0afb65ffbea11a2a4fe760a2abd","ref":"refs/heads/master","pushedAt":"2024-05-10T00:38:25.000Z","pushType":"push","commitsCount":18,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"cmd/dist: don't copy files ending in ~ to bootstrap directory\n\nThey are editor backup files. They are ignored by .gitignore,\nso they can never be real files in the Go repo.\n\nChange-Id: I58800e6e9f939e0bd21b086243b9260bcc8cd770\nReviewed-on: https://go-review.googlesource.com/c/go/+/584675\nReviewed-by: Than McIntosh \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor ","shortMessageHtmlLink":"cmd/dist: don't copy files ending in ~ to bootstrap directory"}},{"before":"a878d3dfa0f9d7cd1de26e3df9eb3983a9f64b53","after":"49eedfb4d07ab6c0d62041ba722dfe81e73d92ce","ref":"refs/heads/master","pushedAt":"2024-05-09T08:51:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"net: use port 53 when checking for UDP routes\n\nUsing port 9 is weird and at least once triggered a suspicious\nactivity alert.\n\nFixes #67264\n\nChange-Id: If4179f054829c175b9f3a51c3bc2a3ca4afa74b9\nReviewed-on: https://go-review.googlesource.com/c/go/+/584416\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"net: use port 53 when checking for UDP routes"}},{"before":"4ed358b57efdad9ed710be7f4fc51495a7620ce2","after":"a878d3dfa0f9d7cd1de26e3df9eb3983a9f64b53","ref":"refs/heads/master","pushedAt":"2024-05-09T00:18:24.000Z","pushType":"push","commitsCount":17,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"encoding/hex: don't overallocate memory in DecodeString\n\nNow as []byte(string) doesn't always cause heap allocation (CL 520599, #2205)\nwe can make DecodeString simpler and more performant, by not allocating\nx2 the required memory.\n\ngoos: linux\ngoarch: amd64\npkg: encoding/hex\ncpu: AMD Ryzen 5 4600G with Radeon Graphics\n │ beforehex │ afterhex │\n │ sec/op │ sec/op vs base │\nDecodeString/256-12 197.9n ± 1% 172.2n ± 1% -13.01% (p=0.000 n=10)\nDecodeString/1024-12 684.9n ± 1% 598.5n ± 1% -12.61% (p=0.000 n=10)\nDecodeString/4096-12 2.764µ ± 0% 2.343µ ± 1% -15.23% (p=0.000 n=10)\nDecodeString/16384-12 10.774µ ± 1% 9.348µ ± 1% -13.23% (p=0.000 n=10)\ngeomean 1.417µ 1.226µ -13.53%\n\n │ beforehex │ afterhex │\n │ B/s │ B/s vs base │\nDecodeString/256-12 1.205Gi ± 1% 1.385Gi ± 1% +14.94% (p=0.000 n=10)\nDecodeString/1024-12 1.393Gi ± 1% 1.593Gi ± 1% +14.42% (p=0.000 n=10)\nDecodeString/4096-12 1.380Gi ± 0% 1.628Gi ± 1% +17.97% (p=0.000 n=10)\nDecodeString/16384-12 1.416Gi ± 1% 1.632Gi ± 1% +15.25% (p=0.000 n=10)\ngeomean 1.346Gi 1.556Gi +15.64%\n\n │ beforehex │ afterhex │\n │ B/op │ B/op vs base │\nDecodeString/256-12 256.0 ± 0% 128.0 ± 0% -50.00% (p=0.000 n=10)\nDecodeString/1024-12 1024.0 ± 0% 512.0 ± 0% -50.00% (p=0.000 n=10)\nDecodeString/4096-12 4.000Ki ± 0% 2.000Ki ± 0% -50.00% (p=0.000 n=10)\nDecodeString/16384-12 16.000Ki ± 0% 8.000Ki ± 0% -50.00% (p=0.000 n=10)\ngeomean 2.000Ki 1.000Ki -50.00%\n\n │ beforehex │ afterhex │\n │ allocs/op │ allocs/op vs base │\nDecodeString/256-12 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹\nDecodeString/1024-12 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹\nDecodeString/4096-12 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹\nDecodeString/16384-12 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹\ngeomean 1.000 1.000 +0.00%\n\nChange-Id: I5676e48f222d90786ea18e808cb4ecde9de82597\nGitHub-Last-Rev: aeedf3f6c4a2505ae9cc0ae58a94c6b2f30806fd\nGitHub-Pull-Request: golang/go#67259\nReviewed-on: https://go-review.googlesource.com/c/go/+/584118\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"encoding/hex: don't overallocate memory in DecodeString"}},{"before":"ad10fbd3c4ec7413775028213f4d5089b18926f7","after":"4ed358b57efdad9ed710be7f4fc51495a7620ce2","ref":"refs/heads/master","pushedAt":"2024-05-08T00:25:09.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"go/types, types: represent any using Alias\n\nWhen GODEBUG=gotypesalias=1 is set, use an actual Alias type to\nrepresent any, rather than a legacy alias representation. This makes any\nconsistent with other interface aliases, and will eventually make\nobsolete the various workarounds for formatting any as 'any' rather than\n'interface{}'.\n\nSince any is a global in the Universe scope, we must hijack Scope.Lookup\nto select the correct representation. Of course, this also means that we\ncan't support type checking concurrently while mutating gotypesalias\n(or, in the case of types2, Config.EnableAlias). Some care is taken to\nensure that the type checker panics in the event of this type of misuse.\n\nFor now, we must still support the legacy representation of any, and the\nexisting workarounds that look for a distinguished any pointer. This is\ndone by ensuring that both representations have the same underlying\npointer, and by updating workarounds to consider Underlying.\n\nFixes golang/go#66921\n\nChange-Id: I81db7e8e15317b7a6ed3b406545db15a2fc42f57\nReviewed-on: https://go-review.googlesource.com/c/go/+/580355\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/types, types: represent any using Alias"}},{"before":"619b419a4b1506bde1aa7e833898f2f67fd0e83e","after":"ad10fbd3c4ec7413775028213f4d5089b18926f7","ref":"refs/heads/master","pushedAt":"2024-05-07T00:24:55.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"image/png: remove go-fuzz test\n\nAn identical go1.18 test exists at `src/image/png/fuzz_test.go`.\n\nChange-Id: I3e4db46296fb6a56655f849da8c0689aa5a1c28c\nReviewed-on: https://go-review.googlesource.com/c/go/+/576795\nReviewed-by: qiu laidongfeng2 <2645477756@qq.com>\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase ","shortMessageHtmlLink":"image/png: remove go-fuzz test"}},{"before":"16ce8b3925deaeb72541ee96b6ee23a08fc21dea","after":"619b419a4b1506bde1aa7e833898f2f67fd0e83e","ref":"refs/heads/master","pushedAt":"2024-05-06T00:28:14.000Z","pushType":"push","commitsCount":36,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"os: use stringslite.TrimSuffix\n\nChange-Id: Ie51a1550181c9478455c757fc82a88bc549ad687\nGitHub-Last-Rev: 4b6ffd043b0f2acebb8d2477da17a4d1dfe708ed\nGitHub-Pull-Request: golang/go#67153\nReviewed-on: https://go-review.googlesource.com/c/go/+/583095\nAuto-Submit: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Keith Randall \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"os: use stringslite.TrimSuffix"}},{"before":"99ee616250e865ca8eff8a91bef3824038b411f1","after":"16ce8b3925deaeb72541ee96b6ee23a08fc21dea","ref":"refs/heads/master","pushedAt":"2024-04-30T00:25:36.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"net: fix lookupHost on Plan 9\n\nCL 532217 added the newDNSError function.\n\nHowever, the implementation was not correct on\nPlan 9, which lead TestLookupNoSuchHost to fail.\n\nThis change fixes lookupHost on Plan 9.\n\nFixes #67096.\n\nChange-Id: I39271f7d588b19c1b1608f18a24d871460be09cd\nReviewed-on: https://go-review.googlesource.com/c/go/+/582236\nReviewed-by: Joedian Reid \nRun-TryBot: David du Colombier <0intro@gmail.com>\nLUCI-TryBot-Result: Go LUCI \nTryBot-Result: Gopher Robot \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"net: fix lookupHost on Plan 9"}},{"before":"2dd82d97b67a538700e30d808122a521e3207c3e","after":"99ee616250e865ca8eff8a91bef3824038b411f1","ref":"refs/heads/master","pushedAt":"2024-04-28T00:41:32.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"internal/runtime/atomic: fix TestAnd64 and TestOr64\n\nThe local variable may not be 64bit aligned, which caused arm tests\nto fail.\n\nFixes #67077\n\nChange-Id: Ia3ae4abcc90319cb10cd593bdc7994cc6eeb3a28\nReviewed-on: https://go-review.googlesource.com/c/go/+/581916\nReviewed-by: Alex Brainman \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"internal/runtime/atomic: fix TestAnd64 and TestOr64"}},{"before":"5419f652b6593a0916f7b2155435b945e8ee0fb4","after":"2dd82d97b67a538700e30d808122a521e3207c3e","ref":"refs/heads/master","pushedAt":"2024-04-26T14:09:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"compress: reordering fields to reduce struct sizes\n\nOverall, there are 32 bytes reduced.\n\nChange-Id: I455bf0874b33fa47719f42618e4800c7ff2a9e88\nGitHub-Last-Rev: 7670344c4a643afdec0fdae3d34fdb8ccd81205f\nGitHub-Pull-Request: golang/go#67010\nReviewed-on: https://go-review.googlesource.com/c/go/+/581355\nReviewed-by: Joedian Reid \nReviewed-by: Keith Randall \nAuto-Submit: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"compress: reordering fields to reduce struct sizes"}},{"before":"db5f2b415399da9b653e68aa03f23ce661cc5339","after":"5419f652b6593a0916f7b2155435b945e8ee0fb4","ref":"refs/heads/master","pushedAt":"2024-04-26T01:18:20.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"spec: clarify prose for range over numeric range expressions\n\nFixes #66967.\n\nChange-Id: I7b9d62dcb83bad60b2ce74e2e2bf1a36c6a8ae38\nReviewed-on: https://go-review.googlesource.com/c/go/+/581256\nReviewed-by: Robert Griesemer \nReviewed-by: Ian Lance Taylor \nTryBot-Bypass: Robert Griesemer ","shortMessageHtmlLink":"spec: clarify prose for range over numeric range expressions"}},{"before":"960fa9bf66139e535d89934f56ae20a0e679e203","after":"db5f2b415399da9b653e68aa03f23ce661cc5339","ref":"refs/heads/master","pushedAt":"2024-04-25T04:58:05.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"benshi001","name":"Ben Shi","path":"/benshi001","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24586233?s=80&v=4"},"commit":{"message":"spec: clarify when a range expression is evaluated\n\nIf the range expression is a numeric constant, the\nrange expression is also not evaluated.\n\nChange-Id: I97201e5c136d3d1a87ed1500b19b7199b30bc9ff\nReviewed-on: https://go-review.googlesource.com/c/go/+/581298\nReviewed-by: Robert Griesemer \nReviewed-by: Ian Lance Taylor \nTryBot-Bypass: Robert Griesemer \nAuto-Submit: Robert Griesemer ","shortMessageHtmlLink":"spec: clarify when a range expression is evaluated"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYsK70QA","startCursor":null,"endCursor":null}},"title":"Activity · golangclub/go"}