Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is unknown how to set gftp service bus url properly #1069

Open
2 tasks
lucekdudek opened this issue Dec 7, 2022 · 0 comments
Open
2 tasks

It is unknown how to set gftp service bus url properly #1069

lucekdudek opened this issue Dec 7, 2022 · 0 comments

Comments

@lucekdudek
Copy link
Contributor

lucekdudek commented Dec 7, 2022

As for now, yapapi is passing GSB_URL implicitly via os.environ.

        env = dict(os.environ, RUST_LOG="debug") if self._debug else None
        self._proc = await asyncio.create_subprocess_shell(
            "gftp server", stdout=asyncio.subprocess.PIPE, stdin=asyncio.subprocess.PIPE, env=env
        )

env = dict(os.environ, RUST_LOG="debug") if self._debug else None
self._proc = await asyncio.create_subprocess_shell(
"gftp server", stdout=asyncio.subprocess.PIPE, stdin=asyncio.subprocess.PIPE, env=env
)

This behavior should be changed so it is explicit and doesn't result in unintentional behaviors (e.g. set variables that user would not want to set when using gftp). Additionally we need to allow users to set the gsb url in a clear way from python code level.

  • Change Golem entrypoint so it allows users to pass gsb url without use of env variables
  • Change gftp storage so it only sets GSB_URL and RUST_LOG when starting gftp server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant