Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for KIAM and kube2iam for S3 storage #1452

Open
aqelali opened this issue Nov 8, 2019 · 3 comments · May be fixed by #1484
Open

Support for KIAM and kube2iam for S3 storage #1452

aqelali opened this issue Nov 8, 2019 · 3 comments · May be fixed by #1484

Comments

@aqelali
Copy link

aqelali commented Nov 8, 2019

Is your feature request related to a problem? Please describe.
In our Kubernetes environment, we don't put our AWS creds on our pods, but rather, we use KIAM and proxy all our AWS requests through it where it then attaches the correct creds based on the IAM role we annotate the pods with. I would think a good feature would be to specify an environment variable (something like USE_KUBE_IAM_ROLE) that when set to true bypasses the AWS cred provider initialization in s3.go

Describe the solution you'd like

  1. specify an environment variable (something like USE_KUBE_IAM_ROLE)
  2. When the above env variable is set to true, bypass the AWS cred provider initialization in s3.go and go straight to creating the AWS Session
  3. Add a field in the helm template to specify a pod annotation for the IAM Role and the new environment variable.

Additional context
I have a fork with this change but I was having issues with github creds locally, I can post it when I have resolved these.

@arschles
Copy link
Member

@aqelali this sounds like a great addition, and I'm excited to see your PR if you decide to send it! Let us know if you would like some help figuring out the GitHub creds locally, we'll be here 😄

@aaqel-s
Copy link

aaqel-s commented Dec 5, 2019

@arschles Reopened the MR!

@arschles
Copy link
Member

@aaqel-s thank you 😄. I've left some comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants