Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a test for the continuation token on the minio storage driver #1213

Open
arschles opened this issue May 9, 2019 · 12 comments 路 May be fixed by #1872
Open

Write a test for the continuation token on the minio storage driver #1213

arschles opened this issue May 9, 2019 · 12 comments 路 May be fixed by #1872
Assignees
@gowdabas
Labels
good first issue Great issues for new Athenians to work on! testing improvements or changes to our test code

Comments

@arschles
Copy link
Member

arschles commented May 9, 2019

Is your feature request related to a problem? Please describe.

#1212 fixes the continuation token on the minio cataloger but I don't believe we have a test for it.

Describe the solution you'd like

Let's write a test for it 馃榿

Describe alternatives you've considered

Additional context

#1212 (review)
@arschles arschles added good first issue Great issues for new Athenians to work on! testing improvements or changes to our test code labels May 9, 2019
@j4ng5y
Copy link

j4ng5y commented May 23, 2019

@arschles, I take a stab :D

@arschles
Copy link
Member Author

@j4ng5y sorry for the delay, go ahead!

@arschles
Copy link
Member Author

arschles commented Aug 5, 2019

@j4ng5y can you let us know if you're still interested in taking a stab at this? Absolutely no problem if you're not, I just wanted to check in 馃槃

@gowdabas
Copy link
Contributor

@j4ng5y If you haven't gotten a chance to work on this, can I take it up?

@arschles
Copy link
Member Author

@gowdabas feel free to take this up 馃榿

@ghost
Copy link

ghost commented Sep 19, 2019

@gowdabas are you still interested in taking this?

@gowdabas
Copy link
Contributor

@robjloranger Didn't get a chance to get on to this. Planning to work on it in the next few days. Feel free to take it in case it's holding something else back?

@ghost
Copy link

ghost commented Sep 26, 2019

no, no trouble. Just checking in on old issues 馃槂

@ghost ghost assigned gowdabas Sep 26, 2019
@gowdabas
Copy link
Contributor

@robjloranger Cool, thanks 馃槃

@khareyash05
Copy link

hey @arschles Can i take this one?

@arschles
Copy link
Member Author

@khareyash05 yes, please do.

@ofekatr ofekatr linked a pull request May 8, 2023 that will close this issue
Open
@ofekatr
Copy link

ofekatr commented May 8, 2023 •
edited

Hello there, in case @khareyash05 is no longer working on this issue, I went ahead and also gave it a shot.
The tests are being introduced in #1872 .
A review would be much appreciated :shipit:

cc @arschles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gowdabas gowdabas

Labels
good first issue Great issues for new Athenians to work on! testing improvements or changes to our test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: storage catalog ofekatr/athens
5 participants
@arschles @gowdabas @j4ng5y @ofekatr @khareyash05