Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not clear #1913

Open
hydezhao opened this issue Jan 12, 2024 · 2 comments
Open

Error message not clear #1913

hydezhao opened this issue Jan 12, 2024 · 2 comments
Labels
triage Issues that need to be verified

Comments

@hydezhao
Copy link

Describe the bug
A clear and concise description of what the bug is.

When configuring the proxy ( version 0.13.1) with :

            downloadURL =  "https://proxy.golang.org"
            mode =  "redirect"

I got lots of error messages in log like:

ERROR[2:39PM]: redirect	http-method=GET http-path=/gopkg.in/gorp.v1/@v/v1.7.2.zip request-id=613a7b67-3b2f-4814-a293-73bd370c4088
INFO[2:39PM]: incoming request	http-method=GET http-path=/gopkg.in/gorp.v1/@v/v1.7.2.zip http-status=301 request-id=613a7b67-3b2f-4814-a293-73bd370c4088

while in logs of go download i see:

# get https://athens.example.com/gopkg.in/gorp.v1/@v/v1.7.2.mod: 200 OK (0.062s)

meaning it successfully downloaded the package.

So, what does the ERROR message mean in log ?

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • OS: [e.g. Linux 64bit] Linux
  • Go version :
  • Proxy version : 0.13.1
  • Storage (fs/mongodb/s3 etc.) : s3

Additional context
Add any other context about the problem here.

@matt0x6F
Copy link
Contributor

From what I can determine this is standard when you set mode to redirect.

It looks like if the target zipped archive is not present on the system then it redirects the caller to the URL of where the archive can be found without storing it.

@hydezhao is your point that it shouldn't be an error and is better described as intended functionality?

@hydezhao
Copy link
Author

Hello @matt0x6F yes exactly. If there is no "error" we shouldn't tag the log with ERROR, which spams the log and creates confusion .

@matt0x6F matt0x6F added the triage Issues that need to be verified label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues that need to be verified
Projects
None yet
Development

No branches or pull requests

2 participants