Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction pages are broken #1958

Closed
matt0x6F opened this issue May 2, 2024 · 0 comments · Fixed by #1965
Closed

Introduction pages are broken #1958

matt0x6F opened this issue May 2, 2024 · 0 comments · Fixed by #1965
Labels
bug Something isn't working
Milestone

Comments

@matt0x6F
Copy link
Contributor

matt0x6F commented May 2, 2024

Describe the bug

The bug is two fold:

  1. Introduction pages do not appear to load the file from disk the way the configuration claims. There's tests that assert this behavior and I've simulated it locally, but when I ran it in production it doesn't seem to work.
  2. The Content-Type header that Chrome receives first is the one that is honored. In our case, the right content type is sent, but it's second because of an existing bug in Athens. Firefox doesn't seem to do this, it takes the last Content-Type header.

Error Message
The content is rendered as application/json and the in-memory template is loaded even when a file is specified.

To Reproduce

  1. Specify a location with https://github.com/gomods/athens/blob/main/config.dev.toml#L174

  2. Launch an image

  3. curl -v the root endpoint

Expected behavior

An HTML page is shown, if specified the custom one, and it is rendered as HTMl by the browser.

Environment (please complete the following information):

  • OS: Linux 64bit
  • Go version : 1.22
  • Proxy version : v0.14.0
  • Storage (fs/mongodb/s3 etc.) : FS

Additional context
N/A

@matt0x6F matt0x6F added the bug Something isn't working label May 2, 2024
@matt0x6F matt0x6F added this to the 0.14.1 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant