Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat_game_base.py prints lots of stuff during testing #1228

Closed
tacertain opened this issue May 15, 2024 · 0 comments · Fixed by #1234
Closed

chat_game_base.py prints lots of stuff during testing #1228

tacertain opened this issue May 15, 2024 · 0 comments · Fixed by #1234
Labels
fixed This is fixed internally, and will be merged in the next github sync!

Comments

@tacertain
Copy link
Contributor

When open_spiel/integration_tests/playthrough_test.py is run, most of the tests run silently, giving output such as:

[ RUN      ] PlaythroughTest.test_playthrough_pig_3p.txt
[       OK ] PlaythroughTest.test_playthrough_pig_3p.txt
[ RUN      ] PlaythroughTest.test_playthrough_pig_4p.txt
[       OK ] PlaythroughTest.test_playthrough_pig_4p.txt
[ RUN      ] PlaythroughTest.test_playthrough_pig_5p.txt
[       OK ] PlaythroughTest.test_playthrough_pig_5p.txt
[ RUN      ] PlaythroughTest.test_playthrough_python_block_dominoes.txt
[       OK ] PlaythroughTest.test_playthrough_python_block_dominoes.txt

However, chat_game_base.py prints lots and lots of output, such as:

I0514 19:03:37.891809 139833831002112 chat_game_base.py:438] Extracting payoff 0 (player=1:Suzy)...
I0514 19:03:37.891947 139833831002112 chat_game_base.py:444] LLM prompt:
Extract out the final value for Suzy as a single numeric value from the following payoff valuation. Do NOT show your work:

5


Result:
I0514 19:03:37.892134 139833831002112 chat_game_base.py:450] LLM response:
5

I0514 19:03:37.892304 139833831002112 chat_game_base.py:460] Extracted integer payoff (Suzy): 5
I0514 19:03:37.892467 139833831002112 chat_game_base.py:428] Calculating payoff 1 (player=1:Suzy)...

It makes it much harder to scan through the results for things going poorly.

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! fixed This is fixed internally, and will be merged in the next github sync! and removed imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This is fixed internally, and will be merged in the next github sync!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants