Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for type guard on optimized set membership step #678

Merged
merged 2 commits into from Apr 7, 2023
Merged

Fix for type guard on optimized set membership step #678

merged 2 commits into from Apr 7, 2023

Conversation

TristonianJones
Copy link
Collaborator

There's a missing check for error / unknown before accessing the pre-computed value map

jnthntatum
jnthntatum requested changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@jnthntatum jnthntatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a motivating test case for coverage?

@TristonianJones
Copy link
Collaborator Author

Thanks! PTAL.

@jnthntatum jnthntatum merged commit f564fe1 into google:master Apr 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnthntatum jnthntatum jnthntatum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TristonianJones @jnthntatum