Presence test cost tracking options #721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #711, presence tests began getting tracked with the same cost as a typical select expression, but this may break some users. A new set of functional options have been added to both the
checker
andinterpreter
packages to allow users to opt-out of this change.Also, note this change breaks the current API contract for
interpreter.CostTracker
andchecker.Cost
. Prefer usinginterpreter.NewCostTracker()
which accepts a set of functional arguments for configuring behavior and which may return an error. Likewise, thechecker.Cost
will returnCostEstimate, error
whereas before it did not. Note, the top-levelcel.EstimateCost()
function signature remains unchanged.