Migrate the checker.Coster to the ast.Expr #798
Merged
+83
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, this is a breaking changes as the type of the checker.AstNode has been modified to return a Go-native Expr value rather than its protobuf equivalent.
TristonianJones
force-pushed
the
coster-expr-update
branch
from
0645b92 to
6f09aff
Compare
jcking
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the checker.Coster interfaces to ast.Expr.
This is a breaking change as the signature of the checker.AstNode.Expr
has changed from a protobuf type to an ast.Expr type.