Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stable ordering of overload candidates #817

Merged
merged 1 commit into from Aug 19, 2023

Conversation

TristonianJones
Copy link
Collaborator

Ensure stable ordering of overload candidates

There was a map traversal happening during dynamic dispatch
which would cause random ordering of overload candidates, and
in cases where the overload resolution was ambiguous, the result
might randomly fail.

Closes #816

Copy link
Collaborator

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TristonianJones TristonianJones merged commit 2de9952 into google:master Aug 19, 2023
2 checks passed
@TristonianJones TristonianJones deleted the overload-order-fix branch August 19, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible regression in type handling
2 participants