You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the goog.testing.TestCase.Test constructor the setUp and tearDown properties are extracted from objChain without using quoted string syntax. Therefore this breaks when the Closure Compiler's advanced optimizations are on, as these setUp accesses get renamed to something that doesn't match the property names in the test code.
The text was updated successfully, but these errors were encountered:
Alternatively, if we don't really have a good way to set up a regression test (we don't compile our tests internally, obviously/unfortunately), maybe you could send a PR that you've verified works for your case?
It prints three log messages when compiled in the SIMPLE mode, and only one in the ADVANCED mode.
As for the fix - I believe you already prepared the fix that seems to coincide with the patch that I made locally in my fork: GoogleChromeLabs/chromeos_smart_card_connector#519.
I didn't upload it as a PR myself as I wasn't sure it covers all possible cases. In particular, I was unsure whether goog.testing.TestCase.setUp needs to be quoted too (can it be passed in objChain to goog.testing.TestCase.Test?).
In the
goog.testing.TestCase.Test
constructor thesetUp
andtearDown
properties are extracted fromobjChain
without using quoted string syntax. Therefore this breaks when the Closure Compiler's advanced optimizations are on, as these setUp accesses get renamed to something that doesn't match the property names in the test code.The text was updated successfully, but these errors were encountered: