Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP]: No error is reported when @AndroidEntryPoint class does not extend a generated Hilt_ class #4018

Open
bcorso opened this issue Aug 16, 2023 · 0 comments

Comments

@bcorso
Copy link

bcorso commented Aug 16, 2023

Due to a bug in KSP (google/ksp#1232) we are unable to get the simple name of the Hilt_ super type. Thus, we're unable to report an error when an @AndroidEntryPoint-annotated class does not extend Hilt's generated, Hilt_, class.

Fortunately, this does not affect users of the Hilt Gradle Plugin, since users of the plugin do not need to extend Hilt's generated class.

For now, we have disabled this check when using Dagger's KSP processors, but we should enable it once google/ksp#1232 is fixed.

@bcorso bcorso changed the title [Hilt KSP]: No error is reported when @AndroidEntryPoint class does not extend a generated Hilt_ class [KSP]: No error is reported when @AndroidEntryPoint class does not extend a generated Hilt_ class Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant