Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki/Documentation: Suggested function name should be diff_wordsToChars #126

Open
ztiromoritz opened this issue Jun 25, 2022 · 0 comments
Open

Comments

@ztiromoritz
Copy link

In the first sentence in the section about a word mode:

https://github.com/google/diff-match-patch/wiki/Line-or-Word-Diffs#word-mode

Computing a word-mode diff is exactly the same as the line-mode diff, except you will have to make a copy of diff_linesToChars and call it diff_linesToWords.

The function should be renamed to "diff_wordsToChars", not "diff_linesToWords".

Because words will be mapped to single chars, if you do the suggested modification.
Analogous to lines that will be mapped to single chars in the original function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant