Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project abandoned / dead / maintained? #143

Open
jmthomas opened this issue May 16, 2023 · 8 comments
Open

Project abandoned / dead / maintained? #143

jmthomas opened this issue May 16, 2023 · 8 comments

Comments

@jmthomas
Copy link

@NeilFraser, @nikolas, @alur: Is this project still active? I haven't seen any commits for 4 yrs. This is an awesome library that a lot of downstream tools are using so I hope that it is still actively maintained. If it is not maintained is there something new that Google has moved on to that the community should consider? Thanks!

@dmsnell
Copy link

dmsnell commented May 16, 2023

@jmthomas just recently I made the decision to do final cleanup on #80 and merge it into my fork's master branch and start using my fork. I really love this library and want to keep it all centralized as much as possible, but there are very devastating flaws with breaking unicode that I fixed a couple years ago and has been doing well.

I'm willing to maintain my fork, or possibly shepherd it within the WordPress organization. still would rather that @NeilFraser provide guidance here, or provide some way to keep this repo active. otherwise I would invite you to try my branch out or follow my fork once I merge it.

@dylans
Copy link

dylans commented Jul 21, 2023

@dmsnell given that it's been 4 years since the last main update, I think a fork is fine. 😂 Would be awesome to see a fork land and have the JS version published to npm and modularized.

@TheSpyder
Copy link

@dmsnell we're looking to use this library in an upcoming TinyMCE feature, we would very much appreciate if you could maintain a fork. Your branch works very well in our testing.

@TheSpyder
Copy link

We're going to try moving ahead with a private deployment of the fork (it's for a closed-source feature). We aren't planning to customise it, so we will switch to a public fork should one become available.

@dmsnell
Copy link

dmsnell commented Jan 31, 2024

All: I have now merged in my own fixes for the split-surrogate issue and it's in my fork's main branch. I intend on maintaining my fork, with consent from @NeilFraser, but I cannot maintain this fork because of the Google ownership.

I will do my best to be responsive and active, though my time is also limited. Your contributions are invited at dmsnell/diff-match-patch and I'll see what I can do to slowly address the backlog of PRs open on this repo.

@dylans sounds great. would you be willing to help publish an npm package? I suspect we'll need to change the module style and possibly generate both a CommonJS module as well as an ESModule. Because I think it will involve multiple steps, I've created a tracking issue for it in my fork.

@TheSpyder
Copy link

Fantastic! I haven't had a chance to finalise our private copy yet, so I will gladly switch to yours 👍

I completely understand that this means using your github project, not google's, from here on out.

@dmsnell
Copy link

dmsnell commented Jan 31, 2024

@TheSpyder please be aware that there is no npm module yet, so you will need to import the JavaScript file directly, as I assume you already know.

@TheSpyder
Copy link

TheSpyder commented Jan 31, 2024

That will be not be harder than what I was trying to do already 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants