From 882d7c909cb79817203375d537cba199459319f1 Mon Sep 17 00:00:00 2001
From: Liam Miller-Cushon <cushon@google.com>
Date: Sat, 22 Jan 2022 22:35:23 -0800
Subject: [PATCH] Improve repro for b/165671890

PiperOrigin-RevId: 423598508
---
 .../errorprone/bugpatterns/OrphanedFormatStringTest.java  | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/OrphanedFormatStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/OrphanedFormatStringTest.java
index c09364623df..411eef33ad4 100644
--- a/core/src/test/java/com/google/errorprone/bugpatterns/OrphanedFormatStringTest.java
+++ b/core/src/test/java/com/google/errorprone/bugpatterns/OrphanedFormatStringTest.java
@@ -104,15 +104,17 @@ public void formatMethod() {
         .doTest();
   }
 
+  // "$ f" is a valid format string, because ' ' is a flag
+  // TODO(b/165671890): consider adding a heuristic to skip these
   @Test
-  public void percent() {
+  public void spaceAfterPercent() {
     testHelper
         .addSourceLines(
             "Test.java",
             "class Test {",
             "  void f() {",
-            "    StringBuilder messageBuilder = ",
-            "        new StringBuilder(\"hakuna % matata\").append(\"y\").append(\"n\");",
+            "    // BUG: Diagnostic contains:",
+            "    StringBuilder messageBuilder = new StringBuilder(\"more than 50% finished\");",
             "  }",
             "}")
         .doTest();