implement FormatString for Java 15 String#formatted #2798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codylerum
force-pushed
the
string_formatted
branch
from
c8fe1e2
to
4de4fb0
Compare
cushon
requested changes
Jan 7, 2022
core/src/test/java/com/google/errorprone/bugpatterns/formatstring/FormatStringTest.java
Show resolved
Hide resolved
core/src/main/java/com/google/errorprone/bugpatterns/formatstring/FormatString.java
Outdated
Show resolved
Hide resolved
cushon
reviewed
Jan 7, 2022
core/src/test/java/com/google/errorprone/bugpatterns/formatstring/FormatStringTest.java
Show resolved
Hide resolved
core/src/test/java/com/google/errorprone/bugpatterns/formatstring/FormatStringTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/errorprone/bugpatterns/formatstring/FormatString.java
Outdated
Show resolved
Hide resolved
codylerum
force-pushed
the
string_formatted
branch
from
aece100
to
fc702a1
Compare
codylerum
force-pushed
the
string_formatted
branch
from
fc702a1
to
102fc8d
Compare
|
@cushon That worked well and is a much better way of getting the pattern. I'm just not familiar enough with all the tools available when parsing the source code. I squashed everything into one commit and updated the formatting and import order. |
cushon
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an initial pass at an implementation for java 15 and up String.formatted
What I'm doing here is detecting early that this is a formatted call on a string instance and just grabbing the value and all of the arguments and sending them directly to a new validate method.
The old validate method is renamed prepareAndValidate and does the work of extracting the pattern and arguments from the argument this for your traditional String#format calls
fixes #2726