Make SuggestedFixes.updateAnnotationArgumentValues JDK 17-compatible
#2820
Conversation
When running Java 17, `AnnotationTree#toString()` omits parentheses if the annotation tree does not contain any arguments. With this change `#updateAnnotationArgumentValues` no longer relies on the unconditional presence of such parentheses.
| '@' | ||
| + annotation.getAnnotationType().toString() |
There was a problem hiding this comment.
More correct would be to do state.getSourceForNode(annotation.getAnnotationType()), but this method currently does not accept a VisitorState. Let me know if you'd like me to make this change; it appears that all callers do have a VisitorState in scope. (Well, in the open source repository, at least.)
There was a problem hiding this comment.
Thanks for the fix!
Adding passing in the VisitorState as a parameter and using state.getSourceForNode(annotation.getAnnotationType()) SGTM if you want to make that change, but this is a clear improvement as-is, so either way is OK with me.
There was a problem hiding this comment.
Alright, I added one more commit, though arguably the improvement is minimal. (But I can imagine that at some point TreeToString is extended to cover non-BugChecker classes, in which case this change would have to be made anyway.)
|
Tests indicate that this issue applies to JDK 12+. |
| '@' | ||
| + annotation.getAnnotationType().toString() |
There was a problem hiding this comment.
Thanks for the fix!
Adding passing in the VisitorState as a parameter and using state.getSourceForNode(annotation.getAnnotationType()) SGTM if you want to make that change, but this is a clear improvement as-is, so either way is OK with me.
Stephan202
deleted the
improvement/SuggestedFixes-updateAnnotationArgumentValues-jdk-17-compat
branch
|
Sorry, I started merging the PR before your last commit, I'll import that separately |
When running Java 17,
AnnotationTree#toString()omits parentheses ifthe annotation tree does not contain any arguments. With this change
#updateAnnotationArgumentValuesno longer relies on the unconditionalpresence of such parentheses.