-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errorprone not an OSGi bundle #2967
Comments
I don't know very much about OSGi. Is this a regression from earlier versions of Error Prone? Do you know what changed in guice 5.1.0 that worked previously? |
Hello @cushon, |
i also just stumbled on this issue when testing the new guice 6.0.0 rc |
@cushon if you are interested I can provide a PR to implement this (probably next week).
It is simpler to use the |
Just created #3903. Everybody interested, please join the discussion there. |
As suggested in #2967 (comment) this PR aims to add OSGi runtime metadata to the error-prone jars. It achieves this by employing the [bnd-maven-plugin:bnd-process](https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-maven-plugin#bnd-process-goal) goal to generate the OSGi metadata, like the values of the Manifest headers `Bundle-SymbolicName`, `Import-Package` and `Export-Package`. The schema used for `Bundle-SymbolicName` headers is based on the schema used for the `Automatic-Module-Name` in the error-prone-annotations artifact. With this change additionally all other error-prone artifacts get a `Automatic-Module-Name` too. @cushon can you please review this PR? If you have any question, I would be happy to answer them. Fixes #2967 Fixes #3903 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3903 from HannesWell:osgiMetadata f1ee0a4 PiperOrigin-RevId: 531653111
As suggested in #2967 (comment) this PR aims to add OSGi runtime metadata to the error-prone jars. It achieves this by employing the [bnd-maven-plugin:bnd-process](https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-maven-plugin#bnd-process-goal) goal to generate the OSGi metadata, like the values of the Manifest headers `Bundle-SymbolicName`, `Import-Package` and `Export-Package`. The schema used for `Bundle-SymbolicName` headers is based on the schema used for the `Automatic-Module-Name` in the error-prone-annotations artifact. With this change additionally all other error-prone artifacts get a `Automatic-Module-Name` too. @cushon can you please review this PR? If you have any question, I would be happy to answer them. Fixes #2967 Fixes #3903 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3903 from HannesWell:osgiMetadata f1ee0a4 PiperOrigin-RevId: 531653111
Currently, com.google.errorprone.annotations (version 2.10.0) is not an OSGi bundle. Some entries are missing in MANIFEST.MF:
Would be great if you can change this. Would allow us to upgrate to google/guice 5.1.0
The text was updated successfully, but these errors were encountered: