Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-matched rules are reported as patched #3349

Closed
delanym opened this issue Jul 31, 2022 · 5 comments
Closed

non-matched rules are reported as patched #3349

delanym opened this issue Jul 31, 2022 · 5 comments

Comments

@delanym
Copy link
Contributor

delanym commented Jul 31, 2022

The plugin is reporting patches written to a file, but no file writes are occurring.

<arg>-Xplugin:ErrorProne -XepAllErrorsAsWarnings -XepPatchChecks:DeadException -XepPatchLocation:${project.build.directory}</arg>

These are also logged as warnings, but they result in writes to the patch file

<arg>-Xplugin:ErrorProne -XepAllErrorsAsWarnings -XepPatchChecks:MissingOverride -XepPatchLocation:${project.build.directory}</arg>

<arg>-Xplugin:ErrorProne -XepAllErrorsAsWarnings -XepPatchChecks:DefaultCharset -XepPatchLocation:${project.build.directory}</arg>

@delanym
Copy link
Contributor Author

delanym commented Aug 1, 2022

Today none of the patches are applying, even though they are logged e.g.
Changes were written to /git/walla/walla-maven-plugin/target/error-prone.patch. Please inspect the file and apply with: patch -p0 -u -i error-prone.patch

@Stephan202
Copy link
Contributor

@delanym this sounds similar to #1562, which was fixed in #3236. IIUC that change hasn't been released yet.

@delanym
Copy link
Contributor Author

delanym commented Aug 1, 2022

@Stephan202 it looks like it hasn't been merged either??
Im not sure its the same though. Patches to DefaultCharset were working, and today they aren't. Its very strange.

@Stephan202
Copy link
Contributor

Stephan202 commented Aug 1, 2022

@Stephan202 it looks like it hasn't been merged either??

It was merged; see ad0289b, which is on master. (The Github PR status is misleading; that's merely an artifact of the way in which Google syncs private and OSS code.)

Im not sure its the same though. Patches to DefaultCharset were working, and today they aren't. Its very strange.

Can't help further with that, I'm afraid. (A complete reproduction case would help.)

@delanym
Copy link
Contributor Author

delanym commented Mar 10, 2023

Cant remember what the resolution was here, but Im using -XepPatchLocation:IN_PLACE which works

@delanym delanym closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants