Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop pre-JDK 11 logic from Refaster's Inliner class #3441

Closed
wants to merge 1 commit into from
Closed

Drop pre-JDK 11 logic from Refaster's Inliner class #3441

wants to merge 1 commit into from

Conversation

Stephan202
Copy link
Contributor

No description provided.

@Stephan202
Copy link
Contributor Author

Stephan202 commented Sep 10, 2022 •
edited

@cushon this drops the "dicey" workaround of 733d021.

@copybara-service copybara-service bot mentioned this pull request Sep 12, 2022
Closed
copybara-service bot pushed a commit that referenced this pull request Sep 12, 2022
@java-team-github-bot
Drop pre-JDK 11 logic from Refaster's Inliner class
8241ca0 
Fixes #3441

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3441 from PicnicSupermarket:improvement/simplify-refaster-inliner 725e5cf
PiperOrigin-RevId: 473589732
@Stephan202 Stephan202 deleted the improvement/simplify-refaster-inliner branch September 12, 2022 07:16
@Stephan202
Copy link
Contributor Author

Stephan202 commented Oct 13, 2022 •
edited

My colleagues @Badbond and @nathankooij pointed out that strictly speaking this PR came too early, as JDK-8193367 was fixed in JDK 11.0.9, meaning that with this change Error Prone 2.16 is not compatible with JDK 11.0.8 and prior. This impacted us when updating our fork, as Jitpack by default uses Java 11.0.2. That said, the workaround was not hard. Since JDK 11.0.9 was released almost two years ago, this incompatibility might not be an issue for most/all users, but if reports do come in, perhaps this change should be reverted for now. @cushon let me know if you'd like me to open a PR for that.

@cushon
Copy link
Collaborator

cushon commented Oct 13, 2022

Thanks @Stephan202, leaving this in for now and waiting to see if it causes any issues in practice SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cushon cushon cushon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stephan202 @cushon