Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some BugPattern docs are missing code examples #4248

Closed
elkkhan opened this issue Jan 8, 2024 · 2 comments
Closed

Some BugPattern docs are missing code examples #4248

elkkhan opened this issue Jan 8, 2024 · 2 comments

Comments

@elkkhan
Copy link
Contributor

elkkhan commented Jan 8, 2024 •
edited

Each bug pattern includes code examples of both positive and negative cases; these examples are used in our regression test suite.

this statement from the website BugPatterns section doesn't hold for some BugPatterns - example 1, example 2
@cushon
Copy link
Collaborator

cushon commented Jan 9, 2024

Thanks for pointing that out. We have moved away from including postive and negative examples for all checks, those docs should be updated to reflect that.

@elkkhan elkkhan mentioned this issue Jan 9, 2024
Closed
@elkkhan
Copy link
Contributor Author

elkkhan commented Jan 9, 2024

@cushon thanks for the response, can you take a look at the attached PR pls?

copybara-service bot pushed a commit that referenced this issue Jan 10, 2024
@elkkhan
Remove incorrect statement from BugPattern index doc
f1bcfc1 
#4248

Fixes #4249

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4249 from elkkhan:doc-remove-bugpattern-examples-statement 8c7cf54
PiperOrigin-RevId: 596951382
@copybara-service copybara-service bot mentioned this issue Jan 10, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Jan 11, 2024
@elkkhan
Remove incorrect statement from BugPattern index doc
1842208 
#4248

Fixes #4249

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4249 from elkkhan:doc-remove-bugpattern-examples-statement 8c7cf54
PiperOrigin-RevId: 596951382
copybara-service bot pushed a commit that referenced this issue Jan 11, 2024
@elkkhan
Remove incorrect statement from BugPattern index doc
4929201 
#4248

Fixes #4249

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4249 from elkkhan:doc-remove-bugpattern-examples-statement 8c7cf54
PiperOrigin-RevId: 596951382
copybara-service bot pushed a commit that referenced this issue Jan 11, 2024
@elkkhan
Remove incorrect statement from BugPattern index doc
5a68588 
#4248

Fixes #4249

COPYBARA_INTEGRATE_REVIEW=#4249 from elkkhan:doc-remove-bugpattern-examples-statement 8c7cf54
PiperOrigin-RevId: 597571000
@elkkhan elkkhan closed this as completed Jan 11, 2024
@jaredstehler jaredstehler mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cushon @elkkhan