Use reflect.Value.IsZero

[dsnet]

Now that Go 1.13 is the minimum version, we can use the reflect.Value.IsZero
method instead of our own internal/value.IsZero function.
Interestingly, our IsZero function pre-dates the IsZero method,
but fortunately has the exact same semantics, since both are targetting
semantics defined by the Go language specification.

[dsnet]

I like code deletion. It's when I feel most productive.

[dsnet]

Bleh. GitHub actions is confused. It's hosed on trying to test for Go 1.11 and 1.12 when we have removed those from our CI.

@neild Can you force merge this?

[dnephin]

It looks like github actions it not running tests for 1.11/1.12, but those checks are marked as "required" in project settings.

That can be fixed under project settings: https://github.com/google/go-cmp/settings/branches, under "Require status checks to pass before merging"

[neild]

Fixed the branch settings to no longer check for 1.11/1.12.

[pmaloogoogle]

hi,
This change seems to have broken us. we are running go get github.com/google/go-cmp/cmp as a step in Dockerfile to build an image. Wanted to check if you have any recommendations on how to move forward. Thanks.

Error:

Step 7/11 : RUN go get github.com/google/go-cmp/cmp
---> Running in 39675da5c0fb
github.com/google/go-cmp/cmp
src/github.com/google/go-cmp/cmp/report_compare.go:249:29: r.Value.ValueX.IsZero undefined (type reflect.Value has no field or method IsZero)
src/github.com/google/go-cmp/cmp/report_compare.go:249:56: r.Value.ValueY.IsZero undefined (type reflect.Value has no field or method IsZero)
src/github.com/google/go-cmp/cmp/report_compare.go:251:29: r.Value.ValueX.IsZero undefined (type reflect.Value has no field or method IsZero)
src/github.com/google/go-cmp/cmp/report_compare.go:253:29: r.Value.ValueY.IsZero undefined (type reflect.Value has no field or method IsZero)
src/github.com/google/go-cmp/cmp/report_reflect.go:187:9: vv.IsZero undefined (type reflect.Value has no field or method IsZero)
The command '/bin/sh -c go get github.com/google/go-cmp/cmp' returned a non-zero code: 2

[dsnet]

What version of Go are you using? The minimally supported version of Go by this package is Go 1.13.

The reflect.Value.IsZero method was added in Go 1.13: https://go.dev/doc/go1.13#reflect

[pmaloogoogle]

Thanks for your reply. We are installing golang in a previous step using the following cmd - apt-get update && apt-get install -y golang

[pmaloogoogle]

go version returns go version go1.10.4 linux/amd64

[pmaloogoogle]

we will plan to update to go 1.13. Thanks.