diff --git a/github/users_packages.go b/github/users_packages.go index 4308b16e1b..cd20f8c189 100644 --- a/github/users_packages.go +++ b/github/users_packages.go @@ -115,13 +115,17 @@ func (s *UsersService) RestorePackage(ctx context.Context, user, packageType, pa // // GitHub API docs: https://docs.github.com/en/rest/reference/packages#get-all-package-versions-for-a-package-owned-by-the-authenticated-user // GitHub API docs: https://docs.github.com/en/rest/reference/users#delete-an-email-address-for-the-authenticated-user -func (s *UsersService) PackageGetAllVersions(ctx context.Context, user, packageType, packageName string) ([]*PackageVersion, *Response, error) { +func (s *UsersService) PackageGetAllVersions(ctx context.Context, user, packageType, packageName string, opts *PackageListOptions) ([]*PackageVersion, *Response, error) { var u string if user != "" { u = fmt.Sprintf("users/%v/packages/%v/%v/versions", user, packageType, packageName) } else { u = fmt.Sprintf("user/packages/%v/%v/versions", packageType, packageName) } + u, err := addOptions(u, opts) + if err != nil { + return nil, nil, err + } req, err := s.client.NewRequest("GET", u, nil) if err != nil { diff --git a/github/users_packages_test.go b/github/users_packages_test.go index 41e7698ab8..a087759334 100644 --- a/github/users_packages_test.go +++ b/github/users_packages_test.go @@ -363,7 +363,10 @@ func TestUsersService_Authenticated_ListPackagesVersions(t *testing.T) { }) ctx := context.Background() - packages, _, err := client.Users.PackageGetAllVersions(ctx, "", "container", "hello_docker") + opts := &PackageListOptions{ + String("internal"), String("container"), String("deleted"), ListOptions{Page: 1, PerPage: 2}, + } + packages, _, err := client.Users.PackageGetAllVersions(ctx, "", "container", "hello_docker", opts) if err != nil { t.Errorf("Users.Authenticated_PackageGetAllVersions returned error: %v", err) } @@ -389,12 +392,12 @@ func TestUsersService_Authenticated_ListPackagesVersions(t *testing.T) { const methodName = "PackageGetAllVersions" testBadOptions(t, methodName, func() (err error) { - _, _, err = client.Users.PackageGetAllVersions(ctx, "\n", "", "") + _, _, err = client.Users.PackageGetAllVersions(ctx, "\n", "", "", &PackageListOptions{}) return err }) testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { - got, resp, err := client.Users.PackageGetAllVersions(ctx, "", "", "") + got, resp, err := client.Users.PackageGetAllVersions(ctx, "", "", "", &PackageListOptions{}) if got != nil { t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) } @@ -429,7 +432,10 @@ func TestUsersService_specifiedUser_ListPackagesVersions(t *testing.T) { }) ctx := context.Background() - packages, _, err := client.Users.PackageGetAllVersions(ctx, "u", "container", "hello_docker") + opts := &PackageListOptions{ + String("internal"), String("container"), String("deleted"), ListOptions{Page: 1, PerPage: 2}, + } + packages, _, err := client.Users.PackageGetAllVersions(ctx, "u", "container", "hello_docker", opts) if err != nil { t.Errorf("Users.specifiedUser_PackageGetAllVersions returned error: %v", err) } @@ -455,12 +461,12 @@ func TestUsersService_specifiedUser_ListPackagesVersions(t *testing.T) { const methodName = "PackageGetAllVersions" testBadOptions(t, methodName, func() (err error) { - _, _, err = client.Users.PackageGetAllVersions(ctx, "\n", "", "") + _, _, err = client.Users.PackageGetAllVersions(ctx, "\n", "", "", &PackageListOptions{}) return err }) testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { - got, resp, err := client.Users.PackageGetAllVersions(ctx, "", "", "") + got, resp, err := client.Users.PackageGetAllVersions(ctx, "", "", "", &PackageListOptions{}) if got != nil { t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) }