Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle github_app_authorization webhook #1544

Merged

Conversation

anurag
Copy link
Contributor

@anurag anurag commented May 30, 2020

Fixes #1543 by adding github_app_authorization to the event map used to parse webhooks.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 30, 2020
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #1544 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
+ Coverage   67.90%   67.92%   +0.02%     
==========================================
  Files          94       94              
  Lines        8670     8670              
==========================================
+ Hits         5887     5889       +2     
+ Misses       1882     1880       -2     
  Partials      901      901              
Impacted Files Coverage Δ
github/messages.go 81.17% <ø> (ø)
github/event.go 93.87% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86f060...da94795. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @anurag, thank you!
LGTM.
Merging.

@gmlewis gmlewis merged commit 407d736 into google:master May 30, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseWebHook fails to recognize github_app_authorization
3 participants