New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tokenauth example #1551
Add tokenauth example #1551
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 94 94
Lines 8670 8670
=======================================
Hits 5889 5889
Misses 1880 1880
Partials 901 901 Continue to review full report at Codecov.
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tteeoo.
Just a few minor nits, and then we should be good to merge after a second LGTM.
Formatted comments better for godoc and added a line in basicauth directing to tokenauth for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tteeoo!
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Thank you, @wesleimp! |
Basic authentication via username and password for the GitHub API is deprecated and will be discontinued November 13, 2020.
As such, I think It's important to have an example for how to use a personal access token to authenticate.
This new
tokenauth
example is completely identical tobasicauth
except it creates a*github.Client
usingoauth2.StaticTokenSource
.