Add missing workflow_id field from workflow run #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 94 94
Lines 8670 8670
=======================================
Hits 5889 5889
Misses 1880 1880
Partials 901 901
Continue to review full report at Codecov.
|
gmlewis
requested changes
Jun 15, 2020
There was a problem hiding this comment.
Thank you, @patrickmarabeas, but one tiny tweak, please, then we will be ready for merging.
github/actions_workflow_runs.go
Outdated
| @@ -22,6 +22,7 @@ type WorkflowRun struct { | |||
| Event *string `json:"event,omitempty"` | |||
| Status *string `json:"status,omitempty"` | |||
| Conclusion *string `json:"conclusion,omitempty"` | |||
| WorkflowID *int `json:"workflow_id,omitempty"` | |||
There was a problem hiding this comment.
Let's please change this to *int64.
Whenever we see GitHub use "ID", we've made them 64-bit ints just in case, so I think we should follow the pattern here as well.
Also, you'll see in line 100 below that workflowID is indeed already an int64:
func (s *ActionsService) ListWorkflowRunsByID(ctx context.Context, owner, repo string, workflowID int64, opts *ListWorkflowRunsOptions) (*WorkflowRuns, *Response, error) {
gmlewis
approved these changes
Jun 16, 2020
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing
workflow_idfield from workflow runs endpoint.See docs: https://developer.github.com/v3/actions/workflow-runs