Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for commitMessage and commitTitle of func (*PullRequestsService) Merge #1557

Merged
merged 1 commit into from Jun 16, 2020

Conversation

tfujiwar
Copy link
Contributor

The documentation comments for commitMessage and commitTitle is not consistent with those of GitHub API Reference (they are swapped).

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   67.92%   67.92%           
=======================================
  Files          94       94           
  Lines        8670     8670           
=======================================
  Hits         5889     5889           
  Misses       1880     1880           
  Partials      901      901           
Impacted Files Coverage Δ
github/pulls.go 65.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a2213...da672f7. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tfujiwar !
LGTM.
Merging.

@gmlewis gmlewis merged commit ecafd12 into google:master Jun 16, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants