Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for addOptions func #1568

Merged
merged 1 commit into from Jun 24, 2020
Merged

Fix documentation for addOptions func #1568

merged 1 commit into from Jun 24, 2020

Conversation

alifarooq0
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020 •
edited

Codecov Report

Merging #1568 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1568   +/-   ##
=======================================
  Coverage   67.90%   67.90%           
=======================================
  Files          95       95           
  Lines        8722     8722           
=======================================
  Hits         5923     5923           
  Misses       1892     1892           
  Partials      907      907
Impacted Files Coverage Δ
github/github.go 89.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9fac6...dd159cf. Read the comment docs.

gmlewis
gmlewis approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ali-farooq0!

LGTM.
Merging.

@gmlewis gmlewis merged commit 6aeb564 into google:master Jun 24, 2020
@alifarooq0 alifarooq0 deleted the patch-1 branch June 24, 2020 23:28
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@alifarooq0
Fix documentation for addOptions func (google#1568)
27d6b1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alifarooq0 @gmlewis @googlebot