Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to Star event #1869

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

jloh
Copy link
Contributor

@jloh jloh commented May 7, 2021

Fixes #1868

Hopefully the commit message is okay! Such a small change wasn't really sure what to say.

I believe I followed all the other steps correctly in the CONTRIBUTING.md but let me know if something needs fixing.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #1869 (fc8e536) into master (b3962ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1869   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6769     6769           
=======================================
  Hits         6610     6610           
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3962ed...fc8e536. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jloh !
LGTM.
Merging.

@gmlewis gmlewis merged commit 85c1b28 into google:master May 7, 2021
@jloh jloh deleted the add_missing_types_star branch May 7, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Star event is missing events
2 participants