Update comparisons in test files from reflect to cmp

[sagar23sj]

Replaced all reflect.DeepEqual comparisons in test files with cmp.Equal.

Fixes: #1851

[sagar23sj]

Can someone help me understand, why checks are failing?
I ran all 3 commands go generate, go test, and go vet on my local before pushing the changes, but still, these are somehow failing in checks.

[willnorris]

Looks like there is still a reference to the reflect package, but it's not imported any longer:

Error: github/orgs_members_test.go:835:6: undefined: reflect

https://github.com/google/go-github/pull/1875/checks?check_run_id=2677192197#step:8:9

[sagar23sj]

Looks like there is still a reference to the reflect package, but it's not imported any longer:

Error: github/orgs_members_test.go:835:6: undefined: reflect

https://github.com/google/go-github/pull/1875/checks?check_run_id=2677192197#step:8:9

Thanks for replying, but I checked there is no "reflect" imported for that particular file in the branch I created PR with.

[willnorris]

It looks like you need to rebase onto the upstream master branch, as you're missing some commits that apparently are getting picked up by the CI jobs (notably d39b94d).

I don't entirely understand why it's not simply running the CI jobs against your branch, which should pass, but would then have problems come merge time. Maybe it's automatically trying to merge your changes with master, resulting in these errors?

[sagar23sj]

It looks like you need to rebase onto the upstream master branch, as you're missing some commits that apparently are getting picked up by the CI jobs (notably d39b94d).

I don't entirely understand why it's not simply running the CI jobs against your branch, which should pass, but would then have problems come merge time. Maybe it's automatically trying to merge your changes with master, resulting in these errors?

Thanks @willnorris , I didn't realize my branch was not up to date.
Pushed again after rebasing, I hope checks pass now.

[willnorris]

okay, so now the error about the reflect reference in orgs_members_test.go is correct :) You'll need to switch that one to use the cmp package as well.

[codecov]

Codecov Report

Merging #1875 (80fd6fc) into master (0318e77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1875   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6783     6783           
=======================================
  Hits         6624     6624           
  Misses         86       86           
  Partials       73       73           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0318e77...80fd6fc. Read the comment docs.

[sagar23sj]

okay, so now the error about the reflect reference in orgs_members_test.go is correct :) You'll need to switch that one to use the cmp package as well.

Thanks for helping @willnorris . I have fixed the issue and seems like checks have also passed.

[gmlewis]

Thank you, @sagar23sj and @willnorris !
LGTM.

Awaiting second LGTM before merging.

[willnorris]

@gmlewis oops, looks like I missed catching your issue rename before merging :)

[gmlewis]

😂 No problem, Will!