-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse 'reviewed' event object 'state' property #1886
Conversation
'reviewed' event objects returned by the Timeline Events API have a 'state' property that tells you the state of a submitted review. This commit adds the code to parse this property.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Merging this PR would fix issue #1885. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @campesel !
LGTM.
Awaiting second LGTM before merging.
@gmlewis Thanks for the approval! |
@wesleimp Looks good to you? |
Friendly ping @wesleimp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The Timeline Events API can return a
reviewed
event object when listing events for a pull request. One of the properties of this object isstate
, which tells you the state of a submitted review.The values
state
can have are:commented
changes_requested
approved
This PR adds this field to the
Timeline
struct defined inissues_timeline.go
to make it possible to tell the state of a review when listing pull request events.