Add test cases for JSON resource marshaling #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test cases for following change events : * ProjectChange * ProjectCardChange * ProjectColumnChange Adds Fixes to : google#55
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1902 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 105 105
Lines 6786 6786
=======================================
Hits 6627 6627
Misses 86 86
Partials 73 73 Continue to review full report at Codecov.
|
gmlewis
reviewed
Jun 21, 2021
gmlewis
changed the title
gmlewis
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Thank you, @sagar23sj !
LGTM.
Awaiting second LGTM before meging.
|
Friendly ping @wesleimp |
|
Hmmm... the tests still pass. Merging. |
|
Although after merging, tests fail... so I'm not sure that GitHub was actually testing master. I'll create a PR to fix the tests. |
gmlewis
added a commit
to gmlewis/go-github
that referenced
this pull request
Jul 8, 2021
gmlewis
added a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for following change events :
Relates to : #55