-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix Code Scanning Alert tool field #1904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ganeshkumarsv !
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 105 105
Lines 6786 6786
=======================================
Hits 6627 6627
Misses 86 86
Partials 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these might help
Co-authored-by: Stephen <stephengroat@users.noreply.github.com>
Co-authored-by: Stephen <stephengroat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ganeshkumarsv !
LGTM.
Awaiting second LGTM before merging.
I apologize for the PR name changes. I see now that this is a "fix" and not an addition... and is therefore a breaking API change. |
Friendly ping @wesleimp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The
tool
field on the API response of listing code scanning alerts is a struct instead of a string. This PR fixes the alert tool field to a struct.Github API: https://docs.github.com/en/rest/reference/code-scanning#list-code-scanning-alerts-for-a-repository
Deprecation notice from Github: The tool_name field is deprecated and will, in future, not be included in the response for this endpoint. The example response reflects this change. The tool name can now be found inside the tool field.
https://docs.github.com/en/rest/reference/code-scanning#list-code-scanning-analyses-for-a-repository