Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle MIME parameters in Content-Type Header #1922

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Handle MIME parameters in Content-Type Header #1922

merged 2 commits into from
Jul 8, 2021

Conversation

sagar23sj
Copy link
Contributor

  • Handled MIME parameters in Content-Type Header
  • Added test-cases to support the changes

Fixes: #1874

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 26, 2021
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #1922 (75603e1) into master (eb2b7f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1922   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6786     6790    +4     
=======================================
+ Hits         6627     6631    +4     
  Misses         86       86           
  Partials       73       73
Impacted Files Coverage Δ
github/messages.go 97.05% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2b7f4...75603e1. Read the comment docs.

gmlewis
gmlewis approved these changes Jun 26, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you, @sagar23sj !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis changed the title Handling MIME parameters in Content-Type Header Handle MIME parameters in Content-Type Header Jun 26, 2021
@gmlewis gmlewis requested a review from wesleimp June 26, 2021 16:36
Parker77
Parker77 approved these changes Jul 8, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit b60bde1 into google:master Jul 8, 2021
@gmlewis gmlewis mentioned this pull request Jul 9, 2021
Merged
@shmyer shmyer mentioned this pull request Jul 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@Parker77 Parker77 Parker77 approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidatePayload does not correctly parse mime type from Content-Type header
3 participants
@sagar23sj @gmlewis @Parker77