-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for JSON marshaling for Teams #1941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @emiscode !
Just a couple minor tweaks, please.
a0d9ee7
to
9528b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @emiscode !
LGTM.
In future PRs, please do not use force-push, as it makes it more difficult to review changes made since the last code review. We always use squash-and-merge in this repo, so you can push as many commits as necessary, and they will be merged into one final commit.
Awiating second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whups, it looks like the code needs to be run through gofmt
first, in order for the tests to pass. Please fix.
- Adjusted commit as per reviewer feedback and run go fmt
Codecov Report
@@ Coverage Diff @@
## master #1941 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 105 105
Lines 6786 6786
=======================================
Hits 6627 6627
Misses 86 86
Partials 73 73 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @emiscode !
LGTM.
Awaiting second LGTM before merging.
Thank you @gmlewis! I'm glad to be contributing to this project, and I really appreciated your care with details during your review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Resource covered: Teams