Add test cases for JSON resource marshaling #1965
Merged
+12,804
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EditTitle - EditBody - EditBase - EditRef - EditSHA - ProjectName - ProjectBody - ProjectCardNote - ProjectColumnName - TeamDescription - TeamName - TeamPrivacy - TeamRepository - TeamPermissions - TeamPermissionsFrom - RepositoryVulnerabilityAlert
- Page - TeamChange
- FeedLink - Feeds - FeedLinks
- IssueCommentEvent - IssuesEvent - LabelEvent - MilestoneEvent
- PublicEvent - PullRequestReviewEvent - PushEvent - StatusEvent
- MarketplacePurchaseEvent - OrganizationEvent - PageBuildEvent
- CommitCommentEvent - DeploymentEvent - DeploymentStatusEvent - PackageEvent
- PingEvent - RepositoryDispatchEvent - RepositoryEvent - ReleaseEvent
- ContentReferenceEvent - MemberEvent - MembershipEvent - OrgBlockEvent - GollumEvent
- UserEvent - WatchEvent - WorkflowDispatchEvent - WorkflowRunEvent
- MetaEvent - DeployKeyEvent - DeployKeyEvent - CheckRunEvent
- InstallationEvent - GitHubAppAuthorizationEvent - ForkEvent - DeleteEvent - CreateEvent - RequestedAction
- HeadCommit - PushEventRepository - PushEventRepoOwner
- ProjectColumnEvent - ProjectCardEvent - ProjectEvent
- PullRequestEvent - PullRequestReviewCommentEvent - PullRequestTargetEvent - RepositoryVulnerabilityAlertEvent
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 105 105
Lines 6809 6809
=======================================
Hits 6662 6662
Misses 80 80
Partials 67 67 Continue to review full report at Codecov.
|
|
Hi @gmlewis, Please see if this is acceptable. If yes, then I will close the other PRs consisting of test cases for the event_types.go file. |
gmlewis
approved these changes
Jul 11, 2021
There was a problem hiding this comment.
Yes, @sagar23sj - this looks great... let's run with this.
Thank you!
LGTM.
Awaiting second LGTM before merging.
|
Thanks, @gmlewis. I will go ahead and close other PRs then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All resources are covered from event_types.go file.
Helps with issue: #55