-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for JSON resource marshaling #1988
Conversation
- ServiceHook - CodeOfConduct - markdownRequest
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 105 105
Lines 6809 6809
=======================================
Hits 6662 6662
Misses 80 80
Partials 67 67
Continue to review full report at Codecov.
|
github/misc_test.go
Outdated
@@ -348,3 +348,68 @@ func TestListServiceHooks(t *testing.T) { | |||
return resp, err | |||
}) | |||
} | |||
|
|||
func TestMarkdownRequest_marshal(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestMarkdownRequest_marshal(t *testing.T) { | |
func TestMarkdownRequest_Marshal(t *testing.T) { |
github/misc_test.go
Outdated
testJSONMarshal(t, a, want) | ||
} | ||
|
||
func TestCodeOfConduct_marshal(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestCodeOfConduct_marshal(t *testing.T) { | |
func TestCodeOfConduct_Marshal(t *testing.T) { |
github/misc_test.go
Outdated
testJSONMarshal(t, a, want) | ||
} | ||
|
||
func TestServiceHook_marshal(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestServiceHook_marshal(t *testing.T) { | |
func TestServiceHook_Marshal(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sagar23sj !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Resources Covered :
Helps with issue: #55