Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Github Code scanning Alert fields #2013

Merged
merged 30 commits into from
Jul 20, 2021

Conversation

ganeshkumarsv
Copy link
Contributor

@ganeshkumarsv ganeshkumarsv commented Jul 16, 2021

This PR adds new fields to the Github Code scanning Alert struct to keep the client library updated with the new Github API response.
Github API: https://docs.github.com/en/rest/reference/code-scanning#list-code-scanning-alerts-for-a-repository

@ganeshkumarsv ganeshkumarsv marked this pull request as draft July 16, 2021 20:55
@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 16, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whups, I see now that it is a draft... sorry for the early code review. Ah, well... hopefully some of the comments are useful to you.

Also, I'm confused by the description of this PR...
I would have named it something like Add missing Alert fields. Maybe you can clarify what is deprecated.

Oh, and finally, please remember to run gofmt on your edited files. Thanks.

github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Show resolved Hide resolved
github/code-scanning.go Show resolved Hide resolved
github/code-scanning.go Show resolved Hide resolved
github/code-scanning.go Show resolved Hide resolved
github/code-scanning.go Show resolved Hide resolved
@ganeshkumarsv ganeshkumarsv changed the title Fix deprecated alert fields Add deprecated alert fields Jul 17, 2021
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #2013 (f5839b3) into master (4cbd718) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2013   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         107      107           
  Lines        6897     6897           
=======================================
  Hits         6750     6750           
  Misses         81       81           
  Partials       66       66           
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbd718...f5839b3. Read the comment docs.

@ganeshkumarsv
Copy link
Contributor Author

@gmlewis Yes, the PR is in draft right now. Thanks a lot anyways for your review comments. I have changed the desciption of the PR to Add deprecated alert fields as you mentioned. will address your other comments next week.

@ganeshkumarsv ganeshkumarsv changed the title Add deprecated alert fields Add New Github Code scanning Alert fields Jul 18, 2021
@ganeshkumarsv ganeshkumarsv marked this pull request as ready for review July 19, 2021 14:57
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv - just a few minor tweaks, please.

github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis Thanks a lot for the round 2 review comments. I guess I've addressed them. Please let me know if there is anything left to change. :)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.
Merging.

@gmlewis gmlewis merged commit b8294c3 into google:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants