Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slug field to AppConfig in manifest workflow #2029

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

rpelliard
Copy link
Contributor

Add the slug field from the GitHub manifest response to AppConfig

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #2029 (d84383f) into master (0d84fe1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2029   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         107      107           
  Lines        6901     6901           
=======================================
  Hits         6754     6754           
  Misses         81       81           
  Partials       66       66           
Impacted Files Coverage Δ
github/apps_manifest.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d84fe1...d84383f. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rpelliard !
LGTM.
Merging.

@gmlewis gmlewis merged commit d8a66d0 into google:master Aug 4, 2021
@rpelliard rpelliard deleted the add-appconfig-slug-field branch August 4, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants