-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TokenExpiration to Response #2031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @w-haibara !
In addition to the comments below, please add a new unit test for the new parseTokenExpiration
function.
Also please make sure to run gofmt
on the edited files so that their formatting is standardized.
See CONTRIBUTING.md in the top-level of this repo for more information.
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
=======================================
Coverage 97.86% 97.87%
=======================================
Files 107 107
Lines 6901 6907 +6
=======================================
+ Hits 6754 6760 +6
Misses 81 81
Partials 66 66
Continue to review full report at Codecov.
|
Hi, @gmlewis ! Thanks for the thoughtful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @w-haibara !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @w-haibara !
LGTM.
Awaiting second LGTM before merging.
Thank you, @gmlewis. |
Thank you, for your contributions, @w-haibara ! Your help is greatly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GitHub has been updated to allow you to set the expiration date of your personal access token. And the expiration date is now displayed in the
GitHub-Authentication-Token-Expiration
header of the GItHub API.https://github.blog/changelog/2021-07-26-expiration-options-for-personal-access-tokens/
This PR add
TokenExpiration
field to Response.