Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate WebHookPayload #2032

Merged
merged 7 commits into from Mar 25, 2022
Merged

Deprecate WebHookPayload #2032

merged 7 commits into from Mar 25, 2022

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 6, 2021

Fixes #303.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited

Codecov Report

Merging #2032 (b82aaba) into master (3e8a7f0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
- Coverage   98.04%   98.04%   -0.01%     
==========================================
  Files         117      117              
  Lines       10460    10454       -6     
==========================================
- Hits        10256    10250       -6     
  Misses        140      140              
  Partials       64       64
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/repos_hooks.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8a7f0...b82aaba. Read the comment docs.

@gmlewis gmlewis requested a review from wesleimp August 6, 2021 19:43
@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 6, 2021 

- Coverage   97.87%   97.87%   -0.01%

This looks like a Codecov bug! Please ignore.

@me-diru me-diru mentioned this pull request Dec 24, 2021
Closed
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Mar 21, 2022
@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 21, 2022

@dmitshur - when you have time (no rush), would you mind reviewing this PR since you commented on #303 ?

@gmlewis gmlewis requested a review from dmitshur March 21, 2022 13:00
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 25, 2022
dmitshur
dmitshur reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good, see two inline comments. One of them is a question.

github/repos_hooks.go Show resolved Hide resolved
github/repos_hooks.go Show resolved Hide resolved
dmitshur
dmitshur approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

github/repos_hooks.go Show resolved Hide resolved
github/repos_hooks.go Show resolved Hide resolved
@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

Thank you, @dmitshur !
Merging.

@gmlewis gmlewis merged commit c28ccfd into google:master Mar 25, 2022
@gmlewis gmlewis deleted the i-303-deprecate-WebHookPayload branch March 25, 2022 22:56
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 25, 2022
@gmlewis gmlewis mentioned this pull request Apr 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitshur dmitshur dmitshur approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate WebHookPayload
2 participants
@gmlewis @dmitshur