-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add struct for workflow_job event #2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 107 107
Lines 6907 6909 +2
=======================================
+ Hits 6760 6762 +2
Misses 81 81
Partials 66 66
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @acuteaura !
Could you please also add this new event to ParsePayload
and also a couple more places? If you search for WorkflowRunEvent
then you should be able to find the other locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you, @acuteaura !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77 ! |
This is a new (as of now undocumented) event that has been darkshipped by GitHub.
It provides three actions: queued, started and completed, reusing the existing WorkflowJob struct.
Official documentation is supposedly soon to follow, but advance submission of this PR has been approved by GitHub staff.
You can hold up this PR until it drops. I will update it accordingly.