Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for autolinks #2046

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Add support for autolinks #2046

merged 5 commits into from
Sep 3, 2021

Conversation

alexal
Copy link
Contributor

@alexal alexal commented Aug 18, 2021 •
edited by gmlewis

Fixes: #2044.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited

Codecov Report

Merging #2046 (7759527) into master (39e5418) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
+ Coverage   97.87%   97.88%   +0.01%     
==========================================
  Files         107      108       +1     
  Lines        6907     6942      +35     
==========================================
+ Hits         6760     6795      +35     
  Misses         81       81              
  Partials       66       66
Impacted Files Coverage Δ
github/repos_autolinks.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e5418...7759527. Read the comment docs.

@alexal alexal mentioned this pull request Aug 18, 2021
Closed
@gmlewis gmlewis changed the title feat: Added support for autolinks (#2044). Add support for autolinks (#2044). Aug 18, 2021
gmlewis
gmlewis requested changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexal !
This is looking really good. Please address the mostly-minor issues.

github/repos_autolinks.go Outdated Show resolved Hide resolved
github/repos_autolinks.go Outdated Show resolved Hide resolved
github/repos_autolinks.go Outdated Show resolved Hide resolved
github/repos_autolinks.go Outdated Show resolved Hide resolved
github/repos_autolinks.go Outdated Show resolved Hide resolved
github/repos_autolinks.go Show resolved Hide resolved
github/repos_autolinks.go Show resolved Hide resolved
github/repos_autolinks.go Show resolved Hide resolved
github/repos_autolinks.go Show resolved Hide resolved
github/repos_autolinks.go Show resolved Hide resolved
gmlewis
gmlewis reviewed Aug 18, 2021
View reviewed changes
github/repos_autolinks.go Outdated Show resolved Hide resolved
gmlewis
gmlewis approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexal !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp August 18, 2021 15:28
@gmlewis gmlewis changed the title Add support for autolinks (#2044). Add support for autolinks Aug 18, 2021
@alexal
Copy link
Contributor Author

alexal commented Aug 24, 2021

@wesleimp ,

Just wondering whether you had a chance to review the change?

@alexal
Copy link
Contributor Author

alexal commented Aug 26, 2021

@gmlewis just wondering maybe someone else can review the change instead of @wesleimp ?

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 26, 2021

@gmlewis just wondering maybe someone else can review the change instead of @wesleimp ?

Sure, @alexal , any contributor to this library is welcome to do a code review and give their comments and/or LGTM+Approval. If you have someone in mind, you can ask them directly.

@alexal
Copy link
Contributor Author

alexal commented Aug 26, 2021

@gmlewis I know no one, but you, so this is why I asked. Ok, I will wait, maybe @wesleimp will show up.

@alexal
Copy link
Contributor Author

alexal commented Aug 30, 2021 •
edited

@willnorris could you please review the changes?

@alexal
Copy link
Contributor Author

alexal commented Sep 3, 2021

@dmitshur could you please review the changes?

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 3, 2021

@alexal - I try not to bother Will or Dmitri with requests for code reviews, in general.
Lately, @Parker77 has been really helpful with code reviews. Maybe if he has time, he could check this one out.

Parker77
Parker77 approved these changes Sep 3, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 3, 2021

Thank you, @Parker77!
Merging.

@gmlewis gmlewis merged commit 178eada into google:master Sep 3, 2021
@entropitor entropitor mentioned this pull request Sep 4, 2021
Closed
@gmlewis gmlewis mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@Parker77 Parker77 Parker77 approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for autolinks
3 participants
@alexal @gmlewis @Parker77